Add wsl linter and fix

Signed-off-by: Émile Ré <emile@probo.com>
This commit is contained in:
Émile Ré
2026-05-19 14:51:08 +04:00
parent eedfdcecc8
commit 9156d6a16a
882 changed files with 6068 additions and 574 deletions

View File

@@ -36,6 +36,7 @@ func NewBuilder(getEnv EnvGetter) *Builder {
if getEnv == nil {
getEnv = os.Getenv
}
return &Builder{getEnv: getEnv}
}
@@ -372,6 +373,7 @@ func (b *Builder) Build() (*probodconfig.FullConfig, error) {
if clientID == "" {
continue
}
cfg.Probod.Connectors = append(cfg.Probod.Connectors, probodconfig.ConnectorConfig{
Provider: provider,
Protocol: "oauth2",
@@ -480,6 +482,7 @@ func (b *Builder) getSAMLCredentials() (cert, key string, err error) {
if cert == "" {
cert = b.getEnv("SAML_CERTIFICATE")
}
if key == "" {
key = b.getEnv("SAML_PRIVATE_KEY")
}
@@ -498,6 +501,7 @@ func (b *Builder) getOAuth2SigningKey() string {
if b.oauth2SigningKey != "" {
return b.oauth2SigningKey
}
return b.getEnv("OAUTH2_SERVER_SIGNING_KEY")
}
@@ -516,6 +520,7 @@ func (b *Builder) getEnvOrDefault(key, defaultValue string) string {
if value := b.getEnv(key); value != "" {
return value
}
return defaultValue
}
@@ -525,6 +530,7 @@ func (b *Builder) getEnvIntOrDefault(key string, defaultValue int) int {
return int(intValue)
}
}
return defaultValue
}
@@ -534,6 +540,7 @@ func (b *Builder) getEnvFloatOrDefault(key string, defaultValue float64) float64
return floatValue
}
}
return defaultValue
}
@@ -543,6 +550,7 @@ func (b *Builder) getEnvFloatPtr(key string) *float64 {
return &floatValue
}
}
return nil
}
@@ -553,6 +561,7 @@ func (b *Builder) getEnvIntPtr(key string) *int {
return &v
}
}
return nil
}
@@ -562,6 +571,7 @@ func (b *Builder) getEnvBoolOrDefault(key string, defaultValue bool) bool {
return boolValue
}
}
return defaultValue
}
@@ -572,12 +582,15 @@ func (b *Builder) parseOriginsList(s string) []string {
}
var result []string
for part := range strings.SplitSeq(s, ",") {
part = strings.TrimSpace(part)
part = strings.Trim(part, "\"")
if part != "" {
result = append(result, part)
}
}
return result
}

View File

@@ -114,6 +114,7 @@ func TestBuilder_Build_MissingRequiredEnvVars(t *testing.T) {
_, err := b.Build()
require.Error(t, err)
for _, missing := range tt.wantMissing {
assert.Contains(t, err.Error(), missing)
}
@@ -480,6 +481,7 @@ func TestBuilder_Build_AccessReviewConnectors(t *testing.T) {
require.NoError(t, err)
require.Len(t, cfg.Probod.Connectors, len(providers))
byProvider := make(map[string]probodconfig.ConnectorConfig, len(cfg.Probod.Connectors))
for _, c := range cfg.Probod.Connectors {
byProvider[c.Provider] = c
@@ -539,6 +541,7 @@ func TestBuilder_Build_SlackConnector(t *testing.T) {
rawConfig := connector.RawConfig.(probodconfig.ConnectorConfigOAuth2)
assert.Equal(t, "slack-client-id", rawConfig.ClientID)
assert.Equal(t, "slack-client-secret", rawConfig.ClientSecret)
rawSettings := connector.RawSettings.(map[string]any)
assert.Equal(t, "slack-signing-secret", rawSettings["signing-secret"])
}

View File

@@ -46,6 +46,7 @@ func TestWriteConfig(t *testing.T) {
require.NoError(t, err)
var loaded probodconfig.FullConfig
err = yaml.Unmarshal(data, &loaded)
require.NoError(t, err)
@@ -143,6 +144,7 @@ func TestWriteConfig_CompleteConfig(t *testing.T) {
require.NoError(t, err)
var loaded probodconfig.FullConfig
err = yaml.Unmarshal(data, &loaded)
require.NoError(t, err)