From 8ff68798fbe8d646af7bdcaf6964d1332bb33405 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89mile=20R=C3=A9?= Date: Tue, 26 May 2026 10:07:53 +0200 Subject: [PATCH] fix(cookie-banner): detect browser-extension stack frames MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit STACK_URL_RE only matched `https?://` URLs, so extension URLs (`chrome-extension://`, `moz-extension://`, `safari-web-extension://`) never reached the EXTENSION_URL_RE classifier. The `fromExtension` flag was effectively always false and extension-originated cookie and storage activity was misattributed as `script`. Broaden STACK_URL_RE to also match the three extension schemes so the existing classifier branch fires and sets `fromExtension = true` before the URL parsing path runs. Signed-off-by: Émile Ré --- packages/cookie-banner/src/detectors/initiator.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/cookie-banner/src/detectors/initiator.ts b/packages/cookie-banner/src/detectors/initiator.ts index 7401cb399..e8a454b00 100644 --- a/packages/cookie-banner/src/detectors/initiator.ts +++ b/packages/cookie-banner/src/detectors/initiator.ts @@ -13,7 +13,8 @@ // PERFORMANCE OF THIS SOFTWARE. const EXTENSION_URL_RE = /(?:chrome|moz|safari-web)-extension:\/\//; -const STACK_URL_RE = /https?:\/\/[^\s)'"`]+/g; +const STACK_URL_RE = + /(?:https?|(?:chrome|moz|safari-web)-extension):\/\/[^\s)'"`]+/g; const LINE_COL_SUFFIX_RE = /:\d+(?::\d+)?$/; const MAX_INITIATOR_URL_LENGTH = 1024;