rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Ignore versioned client headers in VCR matcher

Browse Source 
The Google Workspace driver test broke after the dependabot
google.golang.org/api bump (v0.269.0 → v0.277.0): the recorded cassette
embeds X-Goog-Api-Client: gdcl/0.269.0, which the upgraded SDK no
longer sends, so the default matcher rejects every interaction.

Configure the matcher to ignore User-Agent and X-Goog-Api-Client so
cassettes survive client-library version bumps.

Signed-off-by: Sacha Al Himdani <sacha@getprobo.com>
This commit is contained in:
Sacha Al Himdani
2026-05-05 14:58:42 +02:00
parent 88242eed87
commit 8ff0a24f7a
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
pkg/accessreview/drivers/vcr_test.go
View File

@@ -23,6 +23,11 @@ import (
"gopkg.in/dnaeon/go-vcr.v4/pkg/recorder" "gopkg.in/dnaeon/go-vcr.v4/pkg/recorder"
) )
// versionedClientHeaders are HTTP headers that encode SDK or client library
// versions. They are ignored by the matcher so cassettes keep replaying after
// dependency bumps.
var versionedClientHeaders = []string{"User-Agent", "X-Goog-Api-Client"}
// newRecorder creates a go-vcr recorder for the given cassette path. When // newRecorder creates a go-vcr recorder for the given cassette path. When
// the env var is non-empty the recorder runs in record mode, otherwise // the env var is non-empty the recorder runs in record mode, otherwise
// it replays from the committed cassette. A BeforeSave hook strips the // it replays from the committed cassette. A BeforeSave hook strips the
@@ -39,6 +44,10 @@ func newRecorder(t *testing.T, cassettePath string, envVar string) *recorder.Rec
cassettePath, cassettePath,
recorder.WithMode(mode), recorder.WithMode(mode),
recorder.WithSkipRequestLatency(true), recorder.WithSkipRequestLatency(true),
recorder.WithMatcher(cassette.NewDefaultMatcher(
cassette.WithIgnoreAuthorization(),
cassette.WithIgnoreHeaders(versionedClientHeaders...),
)),
recorder.WithHook(func(i *cassette.Interaction) error { recorder.WithHook(func(i *cassette.Interaction) error {
i.Request.Headers.Del("Authorization") i.Request.Headers.Del("Authorization")
return nil return nil