Update counter only on success

Signed-off-by: Sacha Al Himdani <sacha@getprobo.com>

apps/console/src/components/tasks/TaskFormDialog.tsx

@@ -144,8 +144,10 @@ export default function TaskFormDialog(props: Props) {
           },
           connections: [props.connection!],
         },
-        onCompleted: () => {
+        onCompleted: (_response, errors) => {
+          if (!errors) {
             updateStoreCounter(relayEnv, data.measureId, "tasks(first:0)", 1);
+          }
         },
       });
       reset();

apps/console/src/components/tasks/TasksCard.tsx

@@ -165,8 +165,8 @@ function TaskRow(props: TaskRowProps) {
             input: { taskId: props.task.id },
             connections: [props.connectionId],
           },
-          onCompleted: () => {
+          onCompleted: (_response, errors) => {
-            if (params.measureId) {
+            if (!errors && params.measureId) {
               updateStoreCounter(
                 relayEnv,
                 params.measureId,

apps/console/src/hooks/useMutationWithIncrement.ts

@@ -6,10 +6,10 @@ import {
 } from "react-relay";
 import {
   commitLocalUpdate,
+  type Environment,
   type GraphQLTaggedNode,
   type MutationParameters,
 } from "relay-runtime";
-import type RelayModernEnvironment from "relay-runtime/lib/store/RelayModernEnvironment";
 
 const defaultOptions = {
   field: "totalCount",
@@ -36,6 +36,7 @@ export function useMutationWithIncrement<T extends MutationParameters>(
       return mutate({
         ...queryOptions,
         onCompleted: (response, error) => {
+          if (!error) {
             updateStoreCounter(
               relayEnv,
               options.id,
@@ -43,6 +44,7 @@ export function useMutationWithIncrement<T extends MutationParameters>(
               options.value,
               options.field,
             );
+          }
           queryOptions.onCompleted?.(response, error);
         },
       });
@@ -54,7 +56,7 @@ export function useMutationWithIncrement<T extends MutationParameters>(
 }
 
 export function updateStoreCounter(
-  relayEnv: RelayModernEnvironment,
+  relayEnv: Environment,
   recordId: string,
   nodeName: string,
   value: number = 1,

apps/console/src/pages/organizations/measures/tabs/MeasureEvidencesTab.tsx

@@ -180,13 +180,15 @@ function EvidenceRow(props: {
               evidenceId: evidence.id,
             },
           },
-          onCompleted: () => {
+          onCompleted: (_response, errors) => {
+            if (!errors) {
               updateStoreCounter(
                 relayEnv,
                 props.measureId,
                 "evidences(first:0)",
                 -1
               );
+            }
           },
         });
       },