rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add url.PathEscape to remaining url.JoinPath call sites

Browse Source 
Escape all dynamic path segments that were previously unescaped: GitHub
org and login, Sentry orgSlug, Cloudflare accountID, DocuSign accountID,
Microsoft 365 roleID, and Tally/Sentry/GitHub name resolvers.

Signed-off-by: Émile Ré <emile@probo.com>
This commit is contained in:
Émile Ré
2026-05-20 13:06:30 +04:00
parent f0fe70fe1c
commit 8ec07aa697
6 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/accessreview/drivers/github.go
View File

@@ -150,7 +150,7 @@ func (d *GitHubDriver) ListAccounts(ctx context.Context) ([]AccountRecord, error
func (d *GitHubDriver) fetchAllMembers(ctx context.Context) ([]githubMember, error) {
var members []githubMember
u, err := url.JoinPath("https://api.github.com", "orgs", d.org, "members")
u, err := url.JoinPath("https://api.github.com", "orgs", url.PathEscape(d.org), "members")
if err != nil {
return nil, fmt.Errorf("cannot build github members URL: %w", err)
}
@@ -217,7 +217,7 @@ func (d *GitHubDriver) fetchMembersPage(ctx context.Context, url string) ([]gith
func (d *GitHubDriver) fetchAll2FADisabledLogins(ctx context.Context) (map[string]bool, error) {
set := make(map[string]bool)
u, err := url.JoinPath("https://api.github.com", "orgs", d.org, "members")
u, err := url.JoinPath("https://api.github.com", "orgs", url.PathEscape(d.org), "members")
if err != nil {
return nil, fmt.Errorf("cannot build github 2fa-disabled URL: %w", err)
}
@@ -254,7 +254,7 @@ func (d *GitHubDriver) fetchAll2FADisabledLogins(ctx context.Context) (map[strin
}
func (d *GitHubDriver) fetchMembership(ctx context.Context, login string) (*githubMembership, error) {
endpoint, err := url.JoinPath("https://api.github.com", "orgs", d.org, "memberships", login)
endpoint, err := url.JoinPath("https://api.github.com", "orgs", url.PathEscape(d.org), "memberships", url.PathEscape(login))
if err != nil {
return nil, fmt.Errorf("cannot build github membership URL: %w", err)
}
@@ -288,7 +288,7 @@ func (d *GitHubDriver) fetchMembership(ctx context.Context, login string) (*gith
}
func (d *GitHubDriver) fetchUserProfile(ctx context.Context, login string) (*githubUserProfile, error) {
endpoint, err := url.JoinPath("https://api.github.com", "users", login)
endpoint, err := url.JoinPath("https://api.github.com", "users", url.PathEscape(login))
if err != nil {
return nil, fmt.Errorf("cannot build github user profile URL: %w", err)
}