From 8de7add2031402446682d4b648d9ce3480f1e1a7 Mon Sep 17 00:00:00 2001 From: Sacha Al Himdani Date: Fri, 3 Apr 2026 16:01:57 +0200 Subject: [PATCH] Exclude approved-without-signature documents from employee approvals Filter out approval decisions where state is APPROVED but electronic_signature_id is NULL, removing historical approved entries that lack an electronic signature from the employee approvals page. Signed-off-by: Sacha Al Himdani --- pkg/coredata/document_filter.go | 1 + pkg/coredata/document_version_filter.go | 1 + 2 files changed, 2 insertions(+) diff --git a/pkg/coredata/document_filter.go b/pkg/coredata/document_filter.go index 9dd9f3eb1..6a604e438 100644 --- a/pkg/coredata/document_filter.go +++ b/pkg/coredata/document_filter.go @@ -173,6 +173,7 @@ func (f *DocumentFilter) SQLFragment() string { INNER JOIN iam_membership_profiles p ON dvad.approver_id = p.id WHERE dv.document_id = documents.id AND p.identity_id = @employee_identity_id::text + AND NOT (dvad.state = 'APPROVED' AND dvad.electronic_signature_id IS NULL) ) ) ) diff --git a/pkg/coredata/document_version_filter.go b/pkg/coredata/document_version_filter.go index 44163eb2f..2bfac5811 100644 --- a/pkg/coredata/document_version_filter.go +++ b/pkg/coredata/document_version_filter.go @@ -95,6 +95,7 @@ func (f *DocumentVersionFilter) SQLFragment() string { INNER JOIN iam_membership_profiles p ON dvad.approver_id = p.id WHERE dvaq.version_id = document_versions.id AND p.identity_id = @employee_identity_id::text + AND NOT (dvad.state = 'APPROVED' AND dvad.electronic_signature_id IS NULL) ) ) )