Fix misc bugs

Signed-off-by: Émile Ré <emile@getprobo.com>

pkg/server/api/trust/v1/nda_directive.go

@@ -47,6 +47,10 @@ func newNDADirectiveFunc(
 		}
 
 		compliancePage := compliancepage.CompliancePageFromContext(ctx)
+		if compliancePage == nil {
+			logger.ErrorCtx(ctx, "cannot get compliance page from context")
+			return nil, gqlutils.Internal(ctx)
+		}
 
 		if _, err := trustSvc.GetNDAFile(ctx, compliancePage.ID); err != nil {
 			if errors.Is(err, trust.ErrNDAFileNotFound) {

pkg/server/api/trust/v1/v1_resolver.go

@@ -132,10 +132,14 @@ func (r *documentResolver) Access(ctx context.Context, obj *types.Document) (*ty
 		obj.ID,
 	)
 	if err != nil {
-		if errors.Is(err, trust.ErrDocumentAccessNotFound) {
+		if errors.Is(err, trust.ErrMembershipNotFound) || errors.Is(err, trust.ErrDocumentAccessNotFound) {
 			return nil, nil
 		}
 
+		if errors.Is(err, trust.ErrMembershipInactive) {
+			return nil, gqlutils.Forbidden(ctx, err)
+		}
+
 		r.logger.ErrorCtx(ctx, "cannot get document access", log.Error(err))
 		return nil, gqlutils.Internal(ctx)
 	}
@@ -851,11 +855,15 @@ func (r *reportResolver) Access(ctx context.Context, obj *types.Report) (*types.
 		obj.ID,
 	)
 	if err != nil {
-		if errors.Is(err, trust.ErrDocumentAccessNotFound) {
+		if errors.Is(err, trust.ErrMembershipNotFound) || errors.Is(err, trust.ErrDocumentAccessNotFound) {
 			return nil, nil
 		}
 
-		r.logger.ErrorCtx(ctx, "cannot get document access", log.Error(err))
+		if errors.Is(err, trust.ErrMembershipInactive) {
+			return nil, gqlutils.Forbidden(ctx, err)
+		}
+
+		r.logger.ErrorCtx(ctx, "cannot get audit report access", log.Error(err))
 		return nil, gqlutils.Internal(ctx)
 	}
 
@@ -1067,11 +1075,15 @@ func (r *trustCenterFileResolver) Access(ctx context.Context, obj *types.TrustCe
 		obj.ID,
 	)
 	if err != nil {
-		if errors.Is(err, trust.ErrDocumentAccessNotFound) {
+		if errors.Is(err, trust.ErrMembershipNotFound) || errors.Is(err, trust.ErrDocumentAccessNotFound) {
 			return nil, nil
 		}
 
-		r.logger.ErrorCtx(ctx, "cannot get document access", log.Error(err))
+		if errors.Is(err, trust.ErrMembershipInactive) {
+			return nil, gqlutils.Forbidden(ctx, err)
+		}
+
+		r.logger.ErrorCtx(ctx, "cannot get file access", log.Error(err))
 		return nil, gqlutils.Internal(ctx)
 	}
 

pkg/trust/service.go

@@ -319,7 +319,7 @@ func (s *Service) GetNDAFile(
 			}
 
 			if trustCenter.NonDisclosureAgreementFileID == nil {
-				return nil
+				return ErrNDAFileNotFound
 			}
 
 			file = &coredata.File{}