rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix e2e tests

Browse Source 
Signed-off-by: Émile Ré <emile@getprobo.com>
This commit is contained in:
Émile Ré
2026-02-06 14:38:14 +04:00
parent 9243681f1b
commit 8d20220c86
25 changed files with 323 additions and 1142 deletions
Download Patch File Download Diff File Expand all files Collapse all files

155
e2e/console/rbac_test.go
View File

@@ -174,36 +174,6 @@ const (
}
}`
createPeopleMutation = `
mutation CreatePeople($input: CreatePeopleInput!) {
createPeople(input: $input) {
peopleEdge { node { id } }
}
}`
updatePeopleMutation = `
mutation UpdatePeople($input: UpdatePeopleInput!) {
updatePeople(input: $input) {
people { id }
}
}`
deletePeopleMutation = `
mutation DeletePeople($input: DeletePeopleInput!) {
deletePeople(input: $input) {
deletedPeopleId
}
}`
listPeoplesQuery = `
query GetPeoples($id: ID!) {
node(id: $id) {
... on Organization {
peoples(first: 10) { totalCount }
}
}
}`
createVendorMutation = `
mutation CreateVendor($input: CreateVendorInput!) {
createVendor(input: $input) {
@@ -274,7 +244,6 @@ func TestRBAC(t *testing.T) {
measureID := factory.NewMeasure(owner).WithName("RBAC Test Measure").Create()
taskID := factory.NewTask(owner, measureID).WithName("RBAC Test Task").Create()
riskID := factory.NewRisk(owner).WithName("RBAC Test Risk").Create()
peopleID := factory.NewPeople(owner).WithFullName("RBAC Test Person").Create()
vendorID := factory.NewVendor(owner).WithName("RBAC Test Vendor").Create()
tests := []struct {
@@ -904,130 +873,6 @@ func TestRBAC(t *testing.T) {
},
shouldAllow: true,
},
{
name: "owner can create people",
role: "owner",
client: owner,
query: createPeopleMutation,
variables: func() map[string]any {
return map[string]any{"input": map[string]any{"organizationId": owner.GetOrganizationID().String(), "fullName": factory.SafeName("Person"), "primaryEmailAddress": factory.SafeEmail(), "additionalEmailAddresses": []string{}, "kind": "EMPLOYEE"}}
},
shouldAllow: true,
},
{
name: "admin can create people",
role: "admin",
client: admin,
query: createPeopleMutation,
variables: func() map[string]any {
return map[string]any{"input": map[string]any{"organizationId": owner.GetOrganizationID().String(), "fullName": factory.SafeName("Person"), "primaryEmailAddress": factory.SafeEmail(), "additionalEmailAddresses": []string{}, "kind": "EMPLOYEE"}}
},
shouldAllow: true,
},
{
name: "viewer cannot create people",
role: "viewer",
client: viewer,
query: createPeopleMutation,
variables: func() map[string]any {
return map[string]any{"input": map[string]any{"organizationId": owner.GetOrganizationID().String(), "fullName": factory.SafeName("Person"), "primaryEmailAddress": factory.SafeEmail(), "additionalEmailAddresses": []string{}, "kind": "EMPLOYEE"}}
},
shouldAllow: false,
},
// TODO: Fix server-side issue - updatePeople mutation returns internal server error
// {
// name: "owner can update people",
// role: "owner",
// client: owner,
// query: updatePeopleMutation,
// variables: func() map[string]any {
// return map[string]any{"input": map[string]any{"id": peopleID, "fullName": factory.SafeName("Updated Person")}}
// },
// shouldAllow: true,
// },
// {
// name: "admin can update people",
// role: "admin",
// client: admin,
// query: updatePeopleMutation,
// variables: func() map[string]any {
// return map[string]any{"input": map[string]any{"id": peopleID, "fullName": factory.SafeName("Updated Person")}}
// },
// shouldAllow: true,
// },
{
name: "viewer cannot update people",
role: "viewer",
client: viewer,
query: updatePeopleMutation,
variables: func() map[string]any {
return map[string]any{"input": map[string]any{"id": peopleID, "fullName": factory.SafeName("Updated Person")}}
},
shouldAllow: false,
},
{
name: "owner can delete people",
role: "owner",
client: owner,
query: deletePeopleMutation,
variables: func() map[string]any {
id := factory.NewPeople(owner).WithFullName(factory.SafeName("ToDelete")).Create()
return map[string]any{"input": map[string]any{"peopleId": id}}
},
shouldAllow: true,
},
{
name: "admin can delete people",
role: "admin",
client: admin,
query: deletePeopleMutation,
variables: func() map[string]any {
id := factory.NewPeople(owner).WithFullName(factory.SafeName("ToDelete")).Create()
return map[string]any{"input": map[string]any{"peopleId": id}}
},
shouldAllow: true,
},
{
name: "viewer cannot delete people",
role: "viewer",
client: viewer,
query: deletePeopleMutation,
variables: func() map[string]any {
id := factory.NewPeople(owner).WithFullName(factory.SafeName("ToDelete")).Create()
return map[string]any{"input": map[string]any{"peopleId": id}}
},
shouldAllow: false,
},
{
name: "owner can list peoples",
role: "owner",
client: owner,
query: listPeoplesQuery,
variables: func() map[string]any {
return map[string]any{"id": owner.GetOrganizationID().String()}
},
shouldAllow: true,
},
{
name: "admin can list peoples",
role: "admin",
client: admin,
query: listPeoplesQuery,
variables: func() map[string]any {
return map[string]any{"id": owner.GetOrganizationID().String()}
},
shouldAllow: true,
},
{
name: "viewer can list peoples",
role: "viewer",
client: viewer,
query: listPeoplesQuery,
variables: func() map[string]any {
return map[string]any{"id": owner.GetOrganizationID().String()}
},
shouldAllow: true,
},
{
name: "owner can create vendor",
role: "owner",