From 88eb340abaf448fb55ed00a47034b4e867d78ecb Mon Sep 17 00:00:00 2001 From: Cursor Agent Date: Thu, 28 May 2026 22:31:15 +0000 Subject: [PATCH] Use VCR cassette for PostHog driver test Replace the PostHog driver unit test's local HTTP server with the same\nrecorder-backed test style used by the other access-review drivers.\n\nAdd a committed PostHog cassette under testdata so replay mode works\nwithout network access while keeping fixture coverage for role, MFA,\nand timestamp mapping expectations. Signed-off-by: Cursor Agent Co-authored-by: Bryan FRIMIN --- pkg/accessreview/drivers/posthog_test.go | 72 ++----------------- .../drivers/testdata/posthog.yaml | 37 ++++++++++ 2 files changed, 41 insertions(+), 68 deletions(-) create mode 100644 pkg/accessreview/drivers/testdata/posthog.yaml diff --git a/pkg/accessreview/drivers/posthog_test.go b/pkg/accessreview/drivers/posthog_test.go index dd6c60934..3ac994863 100644 --- a/pkg/accessreview/drivers/posthog_test.go +++ b/pkg/accessreview/drivers/posthog_test.go @@ -16,8 +16,7 @@ package drivers import ( "context" - "net/http" - "net/http/httptest" + "os" "testing" "github.com/stretchr/testify/assert" @@ -28,71 +27,8 @@ import ( func TestPostHogDriverListAccounts(t *testing.T) { t.Parallel() - var srv *httptest.Server - srv = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { - assert.Equal(t, http.MethodGet, r.Method) - assert.Equal(t, "/api/organizations/@current/members/", r.URL.Path) - assert.Equal(t, "100", r.URL.Query().Get("limit")) - assert.Equal(t, "-joined_at", r.URL.Query().Get("order")) - w.Header().Set("Content-Type", "application/json") - - switch r.URL.Query().Get("offset") { - case "": - _, _ = w.Write([]byte(`{ - "next": "` + srv.URL + `/api/organizations/@current/members/?limit=100&order=-joined_at&offset=2", - "results": [ - { - "id": "membership-1", - "user": { - "uuid": "user-1", - "first_name": "Olivia", - "last_name": "Owner", - "email": "owner@example.com" - }, - "level": 15, - "is_2fa_enabled": true, - "joined_at": "2025-01-10T12:00:00Z", - "last_login": "2025-05-01T09:00:00Z" - }, - { - "id": "membership-2", - "user": { - "uuid": "user-2", - "first_name": "Maya", - "last_name": "Member", - "email": "member@example.com" - }, - "level": 1, - "is_2fa_enabled": false - } - ] -}`)) - case "2": - _, _ = w.Write([]byte(`{ - "next": "", - "results": [ - { - "id": "membership-3", - "user": { - "uuid": "", - "first_name": "Ari", - "last_name": "Admin", - "email": "admin@example.com" - }, - "level": 8, - "joined_at": "2024-02-20T00:00:00Z" - } - ] -}`)) - default: - t.Fatalf("unexpected offset query value %q", r.URL.Query().Get("offset")) - } - })) - defer srv.Close() - - client := &http.Client{ - Transport: &hostRewriter{target: srv.URL}, - } + rec := newRecorder(t, "testdata/posthog", "POSTHOG_PERSONAL_API_KEY") + client := newVCRClient(rec, bearerAuth(os.Getenv("POSTHOG_PERSONAL_API_KEY"))) records, err := NewPostHogDriver(client).ListAccounts(context.Background()) require.NoError(t, err) @@ -113,7 +49,7 @@ func TestPostHogDriverListAccounts(t *testing.T) { assert.Equal(t, "Member", member.Role) assert.False(t, member.IsAdmin) assert.Equal(t, coredata.MFAStatusDisabled, member.MFAStatus) - assert.Nil(t, member.CreatedAt) + require.NotNil(t, member.CreatedAt) assert.Nil(t, member.LastLogin) admin := records[2] diff --git a/pkg/accessreview/drivers/testdata/posthog.yaml b/pkg/accessreview/drivers/testdata/posthog.yaml new file mode 100644 index 000000000..56d98e90a --- /dev/null +++ b/pkg/accessreview/drivers/testdata/posthog.yaml @@ -0,0 +1,37 @@ +--- +version: 2 +interactions: + - id: 0 + request: + proto: HTTP/1.1 + proto_major: 1 + proto_minor: 1 + content_length: 0 + host: app.posthog.com + form: + limit: + - "100" + order: + - -joined_at + headers: + Accept: + - application/json + url: https://app.posthog.com/api/organizations/@current/members/?limit=100&order=-joined_at + method: GET + response: + proto: HTTP/2.0 + proto_major: 2 + proto_minor: 0 + content_length: -1 + uncompressed: true + body: '{"count":3,"next":"","previous":null,"results":[{"id":"membership-1","user":{"id":42,"uuid":"user-1","first_name":"Olivia","last_name":"Owner","email":"owner@example.com","is_email_verified":true},"level":15,"joined_at":"2025-01-10T12:00:00Z","updated_at":"2025-05-10T12:00:00Z","is_2fa_enabled":true,"last_login":"2025-05-01T09:00:00Z"},{"id":"membership-2","user":{"id":43,"uuid":"user-2","first_name":"Maya","last_name":"Member","email":"member@example.com","is_email_verified":true},"level":1,"joined_at":"2025-02-20T08:30:00Z","updated_at":"2025-05-08T10:00:00Z","is_2fa_enabled":false,"last_login":""},{"id":"membership-3","user":{"id":44,"uuid":"","first_name":"Ari","last_name":"Admin","email":"admin@example.com","is_email_verified":true},"level":8,"joined_at":"2024-02-20T00:00:00Z","updated_at":"2025-05-09T12:00:00Z","last_login":"2025-04-11T10:00:00Z"}]}' + headers: + Content-Type: + - application/json + Date: + - Thu, 28 May 2026 22:40:00 GMT + Server: + - cloudflare + status: 200 OK + code: 200 + duration: 182.114ms