Truncate access review roles with badge list
Long role strings in the access review table broke row layout when drivers joined many roles into one comma-separated value. Expose roles as a string array in GraphQL by splitting the stored role at the API layer, and render the first three roles as badges with a "+X more" popover for the rest. Closes ENG-459. Signed-off-by: Ludovic Vielle <ludovic@probo.com>
This commit is contained in:
26
pkg/coredata/migrations/20260612T160000Z.sql
Normal file
26
pkg/coredata/migrations/20260612T160000Z.sql
Normal file
@@ -0,0 +1,26 @@
|
||||
-- Copyright (c) 2026 Probo Inc <hello@probo.com>.
|
||||
--
|
||||
-- Permission to use, copy, modify, and/or distribute this software for any
|
||||
-- purpose with or without fee is hereby granted, provided that the above
|
||||
-- copyright notice and this permission notice appear in all copies.
|
||||
--
|
||||
-- THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
|
||||
-- REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
|
||||
-- AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
|
||||
-- INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
|
||||
-- LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
|
||||
-- OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
|
||||
-- PERFORMANCE OF THIS SOFTWARE.
|
||||
|
||||
ALTER TABLE access_review_entries
|
||||
ADD COLUMN roles TEXT[] NOT NULL DEFAULT '{}';
|
||||
|
||||
UPDATE access_review_entries
|
||||
SET roles = CASE
|
||||
WHEN role = '' THEN '{}'::TEXT[]
|
||||
WHEN position(', ' in role) > 0 THEN string_to_array(role, ', ')
|
||||
ELSE ARRAY[role]
|
||||
END;
|
||||
|
||||
ALTER TABLE access_review_entries
|
||||
DROP COLUMN role;
|
||||
Reference in New Issue
Block a user