Truncate access review roles with badge list
Long role strings in the access review table broke row layout when drivers joined many roles into one comma-separated value. Expose roles as a string array in GraphQL by splitting the stored role at the API layer, and render the first three roles as badges with a "+X more" popover for the rest. Closes ENG-459. Signed-off-by: Ludovic Vielle <ludovic@probo.com>
This commit is contained in:
@@ -101,7 +101,7 @@ func (d *QoveryDriver) ListAccounts(ctx context.Context) ([]AccountRecord, error
|
||||
record := AccountRecord{
|
||||
Email: member.Email,
|
||||
FullName: qoveryFullName(member),
|
||||
Role: qoveryRole(member.Role),
|
||||
Roles: qoveryRoles(member.Role),
|
||||
IsAdmin: qoveryIsAdmin(member.Role),
|
||||
MFAStatus: coredata.MFAStatusUnknown,
|
||||
AuthMethod: coredata.AccessReviewEntryAuthMethodUnknown,
|
||||
@@ -139,18 +139,22 @@ func qoveryFullName(member qoveryMember) string {
|
||||
return member.Email
|
||||
}
|
||||
|
||||
func qoveryRole(role string) string {
|
||||
func qoveryRoles(role string) []string {
|
||||
if role == "" {
|
||||
return []string{}
|
||||
}
|
||||
|
||||
switch strings.ToUpper(role) {
|
||||
case "OWNER":
|
||||
return "Owner"
|
||||
return []string{"Owner"}
|
||||
case "ADMIN":
|
||||
return "Admin"
|
||||
return []string{"Admin"}
|
||||
case "DEVELOPER":
|
||||
return "Developer"
|
||||
return []string{"Developer"}
|
||||
case "VIEWER":
|
||||
return "Viewer"
|
||||
return []string{"Viewer"}
|
||||
default:
|
||||
return role
|
||||
return []string{role}
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user