Guard Helm connector env vars on clientId / clientSecret → Address review feedback on access-review drivers

- Guard Helm connector env vars on clientId / clientSecret
- Decode Vercel pagination cursor as *int64
- Drop Monday probe URL — no valid GET endpoint
- Address review feedback on access-review drivers

Signed-off-by: Aurélien Sibiril <81782+aureliensibiril@users.noreply.github.com>
This commit is contained in:
Aurélien Sibiril
2026-05-17 17:22:51 +02:00
parent 995769c4b6
commit 7d0dec82f6
10 changed files with 45 additions and 40 deletions

View File

@@ -402,17 +402,11 @@ func (e *ReviewEngine) resolveDriver(
}
return drivers.NewHerokuDriver(httpClient, herokuSettings.TeamID), nil
case coredata.ConnectorProviderPagerDuty:
// Subdomain is required for the name resolver only; the driver
// itself does not need it because PagerDuty's REST API uses the
// regional api.pagerduty.com host. We still surface a clear
// error if the OAuth callback failed to capture the subdomain.
pdSettings, err := coredata.ConnectorSettings[coredata.PagerDutyConnectorSettings](dbConnector)
if err != nil {
return nil, fmt.Errorf("cannot read pagerduty connector settings: %w", err)
}
if pdSettings.Subdomain == "" {
return nil, fmt.Errorf("pagerduty connector requires subdomain in settings")
}
// PagerDuty's REST API uses the regional api.pagerduty.com host;
// the driver does not consume the per-tenant subdomain. Subdomain
// is read only by the name resolver, which returns empty when
// missing — that surfaces as a blank source name but does not
// block access review.
return drivers.NewPagerDutyDriver(httpClient), nil
case coredata.ConnectorProviderAsana:
asanaSettings, err := coredata.ConnectorSettings[coredata.AsanaConnectorSettings](dbConnector)