Guard Helm connector env vars on clientId / clientSecret → Address review feedback on access-review drivers

- Guard Helm connector env vars on clientId / clientSecret
- Decode Vercel pagination cursor as *int64
- Drop Monday probe URL — no valid GET endpoint
- Address review feedback on access-review drivers

Signed-off-by: Aurélien Sibiril <81782+aureliensibiril@users.noreply.github.com>
This commit is contained in:
Aurélien Sibiril
2026-05-17 17:22:51 +02:00
parent 995769c4b6
commit 7d0dec82f6
10 changed files with 45 additions and 40 deletions

View File

@@ -79,23 +79,20 @@ func (d *AsanaDriver) ListAccounts(ctx context.Context) ([]AccountRecord, error)
}
for _, u := range page.Data {
record := AccountRecord{
// Asana's workspace-users endpoint exposes no active flag,
// and a missing email can mean deactivated, privacy-protected,
// limited-access, or an external collaborator. Inferring
// Active=false from any of those would fabricate state, so
// leave Active nil (unknown) and let downstream review surface
// the gap honestly.
records = append(records, AccountRecord{
Email: u.Email,
FullName: u.Name,
ExternalID: u.GID,
MFAStatus: coredata.MFAStatusUnknown,
AuthMethod: coredata.AccessEntryAuthMethodUnknown,
AccountType: coredata.AccessEntryAccountTypeUser,
}
// Asana hides email for deactivated / privacy-protected users.
// We treat missing email as a defensive Active=false signal.
if u.Email == "" {
active := false
record.Active = &active
}
records = append(records, record)
})
}
if page.NextPage == nil || page.NextPage.URI == "" {