Add Qovery access review driver support

Register Qovery as a connector provider and add a new access review
driver that fetches organization members from the Qovery API.

Extend API key connection handling with a configurable Authorization
token scheme so Qovery can use "Token" while existing providers
continue to default to Bearer.

Signed-off-by: Cursor Agent <cursoragent@cursor.com>

Co-authored-by: Bryan FRIMIN <bryan@frimin.fr>
This commit is contained in:
Cursor Agent
2026-05-29 03:44:39 +00:00
committed by Aurélien Sibiril
parent 9e5d0d1c00
commit 7a43acd3c2
17 changed files with 665 additions and 1 deletions

View File

@@ -51,6 +51,7 @@ func NewBuiltinRegistry() *Registry {
openaiRegistration(),
posthogRegistration(),
pagerdutyRegistration(),
qoveryRegistration(),
resendRegistration(),
sendgridRegistration(),
sentryRegistration(),

View File

@@ -0,0 +1,58 @@
// Copyright (c) 2026 Probo Inc <hello@probo.com>.
//
// Permission to use, copy, modify, and/or distribute this software for any
// purpose with or without fee is hereby granted, provided that the above
// copyright notice and this permission notice appear in all copies.
//
// THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
// REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
// AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
// INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
// LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
// OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
// PERFORMANCE OF THIS SOFTWARE.
package provider
import (
"context"
"fmt"
"net/http"
"go.gearno.de/kit/log"
"go.probo.inc/probo/pkg/accessreview/drivers"
"go.probo.inc/probo/pkg/coredata"
)
func qoveryRegistration() *Registration {
return &Registration{
Provider: coredata.ConnectorProviderQovery,
DisplayName: "Qovery",
SupportsAPIKey: true,
APIKeyAuthScheme: "Token",
ExtraSettings: []ExtraSetting{
{Key: "organizationId", Label: "Organization ID", Required: true},
},
NewDriver: func(_ context.Context, c *http.Client, conn *coredata.Connector, _ *log.Logger) (drivers.Driver, error) {
s, err := coredata.ConnectorSettings[coredata.QoveryConnectorSettings](conn)
if err != nil {
return nil, fmt.Errorf("cannot read qovery connector settings: %w", err)
}
if s.OrganizationID == "" {
return nil, fmt.Errorf("cannot create qovery driver: organization_id is required")
}
return drivers.NewQoveryDriver(c, s.OrganizationID), nil
},
NewNameResolver: func(ctx context.Context, c *http.Client, conn *coredata.Connector, logger *log.Logger) drivers.NameResolver {
s, err := coredata.ConnectorSettings[coredata.QoveryConnectorSettings](conn)
if err != nil {
logger.ErrorCtx(ctx, "cannot read qovery connector settings", log.Error(err))
return nil
}
return drivers.NewQoveryNameResolver(c, s.OrganizationID)
},
}
}

View File

@@ -0,0 +1,106 @@
// Copyright (c) 2026 Probo Inc <hello@probo.com>.
//
// Permission to use, copy, modify, and/or distribute this software for any
// purpose with or without fee is hereby granted, provided that the above
// copyright notice and this permission notice appear in all copies.
//
// THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
// REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
// AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
// INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
// LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
// OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
// PERFORMANCE OF THIS SOFTWARE.
package provider_test
import (
"context"
"encoding/json"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"go.gearno.de/kit/httpclient"
"go.probo.inc/probo/pkg/accessreview/drivers"
"go.probo.inc/probo/pkg/connector/provider"
"go.probo.inc/probo/pkg/coredata"
)
func TestQoveryRegistrationMetadata(t *testing.T) {
t.Parallel()
r := provider.NewBuiltinRegistry()
reg, ok := r.Get(coredata.ConnectorProviderQovery)
require.True(t, ok, "qovery provider must be registered")
assert.Equal(t, "Qovery", reg.DisplayName)
assert.True(t, reg.SupportsAPIKey)
assert.Equal(t, "Token", reg.APIKeyAuthScheme)
require.Len(t, reg.ExtraSettings, 1)
assert.Equal(t, "organizationId", reg.ExtraSettings[0].Key)
assert.Equal(t, "Organization ID", reg.ExtraSettings[0].Label)
assert.True(t, reg.ExtraSettings[0].Required)
}
func TestQoveryNewDriver(t *testing.T) {
t.Parallel()
r := provider.NewBuiltinRegistry()
reg, ok := r.Get(coredata.ConnectorProviderQovery)
require.True(t, ok, "qovery provider must be registered")
require.NotNil(t, reg.NewDriver, "qovery NewDriver closure must be wired")
t.Run("creates driver with valid organization_id", func(t *testing.T) {
t.Parallel()
raw, err := json.Marshal(&coredata.QoveryConnectorSettings{
OrganizationID: "c4f2de4d-3e50-4f98-bf00-065778f7f5b5",
})
require.NoError(t, err)
conn := &coredata.Connector{
Provider: coredata.ConnectorProviderQovery,
RawSettings: raw,
}
drv, err := reg.NewDriver(context.Background(), httpclient.DefaultClient(httpclient.WithSSRFProtection()), conn, nil)
require.NoError(t, err)
assert.IsType(t, &drivers.QoveryDriver{}, drv)
})
t.Run("errors when organization_id is missing", func(t *testing.T) {
t.Parallel()
conn := &coredata.Connector{
Provider: coredata.ConnectorProviderQovery,
RawSettings: []byte(`{}`),
}
_, err := reg.NewDriver(context.Background(), httpclient.DefaultClient(httpclient.WithSSRFProtection()), conn, nil)
require.Error(t, err)
assert.Contains(t, err.Error(), "organization_id is required")
})
}
func TestQoveryNewNameResolver(t *testing.T) {
t.Parallel()
r := provider.NewBuiltinRegistry()
reg, ok := r.Get(coredata.ConnectorProviderQovery)
require.True(t, ok, "qovery provider must be registered")
require.NotNil(t, reg.NewNameResolver, "qovery NewNameResolver closure must be wired")
raw, err := json.Marshal(&coredata.QoveryConnectorSettings{
OrganizationID: "c4f2de4d-3e50-4f98-bf00-065778f7f5b5",
})
require.NoError(t, err)
conn := &coredata.Connector{
Provider: coredata.ConnectorProviderQovery,
RawSettings: raw,
}
resolver := reg.NewNameResolver(context.Background(), httpclient.DefaultClient(httpclient.WithSSRFProtection()), conn, nil)
require.NotNil(t, resolver, "qovery name resolver must be constructed for a valid connector")
}