Add Render access review driver support
Register Render as an API-key connector provider and add an access
review driver that fetches workspace members from the Render API
(GET /v1/owners/{ownerId}/members).
Render exposes no partner OAuth program, so the connector authenticates
with a read-scoped API key (Authorization: Bearer) plus the customer's
Workspace ID. The flat members endpoint reports an explicit account
status and MFA flag, surfaced as the Active and MFAStatus fields; the
stable "usr-" id becomes ExternalID. There is no picker -- the
workspace is captured up front via ExtraSettings -- so
SetOrganizationSettings is omitted.
Signed-off-by: Aurélien Sibiril <81782+aureliensibiril@users.noreply.github.com>
This commit is contained in:
@@ -52,6 +52,7 @@ func NewBuiltinRegistry() *Registry {
|
||||
posthogRegistration(),
|
||||
pagerdutyRegistration(),
|
||||
qoveryRegistration(),
|
||||
renderRegistration(),
|
||||
resendRegistration(),
|
||||
sendgridRegistration(),
|
||||
sentryRegistration(),
|
||||
|
||||
63
pkg/connector/provider/render.go
Normal file
63
pkg/connector/provider/render.go
Normal file
@@ -0,0 +1,63 @@
|
||||
// Copyright (c) 2026 Probo Inc <hello@probo.com>.
|
||||
//
|
||||
// Permission to use, copy, modify, and/or distribute this software for any
|
||||
// purpose with or without fee is hereby granted, provided that the above
|
||||
// copyright notice and this permission notice appear in all copies.
|
||||
//
|
||||
// THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
|
||||
// REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
|
||||
// AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
|
||||
// INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
|
||||
// LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
|
||||
// OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
|
||||
// PERFORMANCE OF THIS SOFTWARE.
|
||||
|
||||
package provider
|
||||
|
||||
import (
|
||||
"context"
|
||||
"fmt"
|
||||
"net/http"
|
||||
|
||||
"go.gearno.de/kit/log"
|
||||
"go.probo.inc/probo/pkg/accessreview/drivers"
|
||||
"go.probo.inc/probo/pkg/coredata"
|
||||
)
|
||||
|
||||
// renderRegistration wires Render as an API-key access-review connector.
|
||||
// Render exposes no partner OAuth program, so the customer supplies a
|
||||
// read-scoped API key plus their Workspace ID (Render's owner ID). The key
|
||||
// authenticates with the default Authorization: Bearer scheme, so no
|
||||
// APIKeyAuthScheme override is set. There is no picker — the workspace is
|
||||
// captured up front via ExtraSettings — so SetOrganizationSettings is omitted.
|
||||
func renderRegistration() *Registration {
|
||||
return &Registration{
|
||||
Provider: coredata.ConnectorProviderRender,
|
||||
DisplayName: "Render",
|
||||
SupportsAPIKey: true,
|
||||
ExtraSettings: []ExtraSetting{
|
||||
{Key: "workspaceId", Label: "Workspace ID", Required: true},
|
||||
},
|
||||
NewDriver: func(_ context.Context, c *http.Client, conn *coredata.Connector, _ *log.Logger) (drivers.Driver, error) {
|
||||
s, err := coredata.ConnectorSettings[coredata.RenderConnectorSettings](conn)
|
||||
if err != nil {
|
||||
return nil, fmt.Errorf("cannot read render connector settings: %w", err)
|
||||
}
|
||||
|
||||
if s.OwnerID == "" {
|
||||
return nil, fmt.Errorf("cannot create render driver: owner_id is required")
|
||||
}
|
||||
|
||||
return drivers.NewRenderDriver(c, s.OwnerID), nil
|
||||
},
|
||||
NewNameResolver: func(ctx context.Context, c *http.Client, conn *coredata.Connector, logger *log.Logger) drivers.NameResolver {
|
||||
s, err := coredata.ConnectorSettings[coredata.RenderConnectorSettings](conn)
|
||||
if err != nil {
|
||||
logger.ErrorCtx(ctx, "cannot read render connector settings", log.Error(err))
|
||||
return nil
|
||||
}
|
||||
|
||||
return drivers.NewRenderNameResolver(c, s.OwnerID)
|
||||
},
|
||||
}
|
||||
}
|
||||
113
pkg/connector/provider/render_test.go
Normal file
113
pkg/connector/provider/render_test.go
Normal file
@@ -0,0 +1,113 @@
|
||||
// Copyright (c) 2026 Probo Inc <hello@probo.com>.
|
||||
//
|
||||
// Permission to use, copy, modify, and/or distribute this software for any
|
||||
// purpose with or without fee is hereby granted, provided that the above
|
||||
// copyright notice and this permission notice appear in all copies.
|
||||
//
|
||||
// THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
|
||||
// REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
|
||||
// AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
|
||||
// INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
|
||||
// LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
|
||||
// OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
|
||||
// PERFORMANCE OF THIS SOFTWARE.
|
||||
|
||||
package provider_test
|
||||
|
||||
import (
|
||||
"context"
|
||||
"encoding/json"
|
||||
"testing"
|
||||
|
||||
"github.com/stretchr/testify/assert"
|
||||
"github.com/stretchr/testify/require"
|
||||
"go.gearno.de/kit/httpclient"
|
||||
"go.probo.inc/probo/pkg/accessreview/drivers"
|
||||
"go.probo.inc/probo/pkg/connector/provider"
|
||||
"go.probo.inc/probo/pkg/coredata"
|
||||
)
|
||||
|
||||
func TestRenderRegistrationMetadata(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
r := provider.NewBuiltinRegistry()
|
||||
reg, ok := r.Get(coredata.ConnectorProviderRender)
|
||||
require.True(t, ok, "render provider must be registered")
|
||||
|
||||
assert.Equal(t, "Render", reg.DisplayName)
|
||||
assert.True(t, reg.SupportsAPIKey)
|
||||
// Render authenticates with the default Authorization: Bearer scheme.
|
||||
assert.Empty(t, reg.APIKeyAuthScheme)
|
||||
assert.Empty(t, reg.APIKeyHeader)
|
||||
assert.False(t, reg.APIKeyBasicAuth)
|
||||
// No OAuth and no picker.
|
||||
assert.Empty(t, reg.AuthURL)
|
||||
assert.Nil(t, reg.SetOrganizationSettings)
|
||||
|
||||
require.Len(t, reg.ExtraSettings, 1)
|
||||
assert.Equal(t, "workspaceId", reg.ExtraSettings[0].Key)
|
||||
assert.Equal(t, "Workspace ID", reg.ExtraSettings[0].Label)
|
||||
assert.True(t, reg.ExtraSettings[0].Required)
|
||||
}
|
||||
|
||||
func TestRenderNewDriver(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
r := provider.NewBuiltinRegistry()
|
||||
reg, ok := r.Get(coredata.ConnectorProviderRender)
|
||||
require.True(t, ok, "render provider must be registered")
|
||||
require.NotNil(t, reg.NewDriver, "render NewDriver closure must be wired")
|
||||
|
||||
t.Run("creates driver with valid owner id", func(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
raw, err := json.Marshal(&coredata.RenderConnectorSettings{
|
||||
OwnerID: "tea-csp8nlbgbbvc73a8nn9g",
|
||||
})
|
||||
require.NoError(t, err)
|
||||
|
||||
conn := &coredata.Connector{
|
||||
Provider: coredata.ConnectorProviderRender,
|
||||
RawSettings: raw,
|
||||
}
|
||||
|
||||
drv, err := reg.NewDriver(context.Background(), httpclient.DefaultClient(httpclient.WithSSRFProtection()), conn, nil)
|
||||
require.NoError(t, err)
|
||||
assert.IsType(t, &drivers.RenderDriver{}, drv)
|
||||
})
|
||||
|
||||
t.Run("errors when owner id is missing", func(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
conn := &coredata.Connector{
|
||||
Provider: coredata.ConnectorProviderRender,
|
||||
RawSettings: []byte(`{}`),
|
||||
}
|
||||
|
||||
_, err := reg.NewDriver(context.Background(), httpclient.DefaultClient(httpclient.WithSSRFProtection()), conn, nil)
|
||||
require.Error(t, err)
|
||||
assert.Contains(t, err.Error(), "owner_id is required")
|
||||
})
|
||||
}
|
||||
|
||||
func TestRenderNewNameResolver(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
r := provider.NewBuiltinRegistry()
|
||||
reg, ok := r.Get(coredata.ConnectorProviderRender)
|
||||
require.True(t, ok, "render provider must be registered")
|
||||
require.NotNil(t, reg.NewNameResolver, "render NewNameResolver closure must be wired")
|
||||
|
||||
raw, err := json.Marshal(&coredata.RenderConnectorSettings{
|
||||
OwnerID: "tea-csp8nlbgbbvc73a8nn9g",
|
||||
})
|
||||
require.NoError(t, err)
|
||||
|
||||
conn := &coredata.Connector{
|
||||
Provider: coredata.ConnectorProviderRender,
|
||||
RawSettings: raw,
|
||||
}
|
||||
|
||||
resolver := reg.NewNameResolver(context.Background(), httpclient.DefaultClient(httpclient.WithSSRFProtection()), conn, nil)
|
||||
require.NotNil(t, resolver, "render name resolver must be constructed for a valid connector")
|
||||
}
|
||||
Reference in New Issue
Block a user