From 72a48ff6b1face99044ed69ff1a4c4eb71efaf29 Mon Sep 17 00:00:00 2001 From: Sacha Al Himdani Date: Fri, 27 Mar 2026 14:21:10 +0100 Subject: [PATCH] Run n8n-node lint on pull requests using n8n-node CLI The PR lint path was running `npx eslint .` for the n8n-node package, which uses a different config than `npx n8n-node lint` used on push. This caused lint to pass on PRs but fail on push to main. Signed-off-by: Sacha Al Himdani --- .github/workflows/make.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/make.yaml b/.github/workflows/make.yaml index 01581084b..1486c5d7c 100644 --- a/.github/workflows/make.yaml +++ b/.github/workflows/make.yaml @@ -171,10 +171,11 @@ jobs: REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | if [ "${{ github.event_name }}" = "pull_request" ]; then - for dir in apps/console apps/trust packages/ui packages/eslint-config packages/n8n-node; do + for dir in apps/console apps/trust packages/ui packages/eslint-config; do (cd "$dir" && npx eslint . --concurrency 4 --format stylish 2>/dev/null) | \ reviewdog -f=eslint -reporter=github-pr-review -filter-mode=nofilter -fail-level=error -name="eslint ($dir)" done + (cd packages/n8n-node && npx n8n-node lint) else npm run lint fi