rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Link measures to third parties

Browse Source 
Add a many-to-many relationship between measures and third parties,
surfaced as a measures tab on the third party detail page and a third
parties tab on the measure detail page. Each side gets a paginated
list with a link/unlink dialog.

Also remove the right-hand drawer on the measure detail page and
expose the state as a badge in the page header, mirroring how the
compliance page surfaces its active flag.

Signed-off-by: Sacha Al Himdani <sacha@getprobo.com>
This commit is contained in:
Sacha Al Himdani
2026-05-22 16:07:48 +02:00
parent b6b1e801b1
commit 6dfdd7ca49
35 changed files with 2109 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

97
pkg/cmd/measure/link-third-party/link_third_party.go vendored Normal file
View File

@@ -0,0 +1,97 @@
// Copyright (c) 2026 Probo Inc <hello@getprobo.com>.
//
// Permission to use, copy, modify, and/or distribute this software for any
// purpose with or without fee is hereby granted, provided that the above
// copyright notice and this permission notice appear in all copies.
//
// THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
// REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
// AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
// INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
// LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
// OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
// PERFORMANCE OF THIS SOFTWARE.
package linkthirdparty
import (
"fmt"
"github.com/spf13/cobra"
"go.probo.inc/probo/pkg/cli/api"
"go.probo.inc/probo/pkg/cmd/cmdutil"
)
const linkThirdPartyMutation = `
mutation($input: CreateMeasureThirdPartyMappingInput!) {
createMeasureThirdPartyMapping(input: $input) {
measureEdge {
node { id }
}
thirdPartyEdge {
node { id }
}
}
}
`
func NewCmdLinkThirdParty(f *cmdutil.Factory) *cobra.Command {
var (
flagMeasureID string
flagThirdPartyID string
)
cmd := &cobra.Command{
Use: "link-third-party",
Short: "Link a third party to a measure",
RunE: func(cmd *cobra.Command, args []string) error {
cfg, err := f.Config()
if err != nil {
return err
}
host, hc, err := cfg.DefaultHost()
if err != nil {
return err
}
client := api.NewClient(
host,
hc.Token,
"/api/console/v1/graphql",
cfg.HTTPTimeoutDuration(),
cmdutil.TokenRefreshOption(cfg, host, hc),
)
_, err = client.Do(
linkThirdPartyMutation,
map[string]any{
"input": map[string]any{
"measureId": flagMeasureID,
"thirdPartyId": flagThirdPartyID,
},
},
)
if err != nil {
return err
}
_, _ = fmt.Fprintf(
f.IOStreams.Out,
"Linked third party %s to measure %s\n",
flagThirdPartyID,
flagMeasureID,
)
return nil
},
}
cmd.Flags().StringVar(&flagMeasureID, "measure-id", "", "Measure ID (required)")
cmd.Flags().StringVar(&flagThirdPartyID, "third-party-id", "", "Third party ID (required)")
_ = cmd.MarkFlagRequired("measure-id")
_ = cmd.MarkFlagRequired("third-party-id")
return cmd
}

4
pkg/cmd/measure/measure.go
View File

@@ -19,7 +19,9 @@ import (
"go.probo.inc/probo/pkg/cmd/cmdutil"
"go.probo.inc/probo/pkg/cmd/measure/create"
"go.probo.inc/probo/pkg/cmd/measure/delete"
linkthirdparty "go.probo.inc/probo/pkg/cmd/measure/link-third-party"
"go.probo.inc/probo/pkg/cmd/measure/list"
unlinkthirdparty "go.probo.inc/probo/pkg/cmd/measure/unlink-third-party"
"go.probo.inc/probo/pkg/cmd/measure/update"
"go.probo.inc/probo/pkg/cmd/measure/view"
)
@@ -35,6 +37,8 @@ func NewCmdMeasure(f *cmdutil.Factory) *cobra.Command {
cmd.AddCommand(view.NewCmdView(f))
cmd.AddCommand(update.NewCmdUpdate(f))
cmd.AddCommand(delete.NewCmdDelete(f))
cmd.AddCommand(linkthirdparty.NewCmdLinkThirdParty(f))
cmd.AddCommand(unlinkthirdparty.NewCmdUnlinkThirdParty(f))
return cmd
}

93
pkg/cmd/measure/unlink-third-party/unlink_third_party.go vendored Normal file
View File

@@ -0,0 +1,93 @@
// Copyright (c) 2026 Probo Inc <hello@getprobo.com>.
//
// Permission to use, copy, modify, and/or distribute this software for any
// purpose with or without fee is hereby granted, provided that the above
// copyright notice and this permission notice appear in all copies.
//
// THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
// REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
// AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
// INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
// LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
// OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
// PERFORMANCE OF THIS SOFTWARE.
package unlinkthirdparty
import (
"fmt"
"github.com/spf13/cobra"
"go.probo.inc/probo/pkg/cli/api"
"go.probo.inc/probo/pkg/cmd/cmdutil"
)
const unlinkThirdPartyMutation = `
mutation($input: DeleteMeasureThirdPartyMappingInput!) {
deleteMeasureThirdPartyMapping(input: $input) {
deletedMeasureId
deletedThirdPartyId
}
}
`
func NewCmdUnlinkThirdParty(f *cmdutil.Factory) *cobra.Command {
var (
flagMeasureID string
flagThirdPartyID string
)
cmd := &cobra.Command{
Use: "unlink-third-party",
Short: "Unlink a third party from a measure",
RunE: func(cmd *cobra.Command, args []string) error {
cfg, err := f.Config()
if err != nil {
return err
}
host, hc, err := cfg.DefaultHost()
if err != nil {
return err
}
client := api.NewClient(
host,
hc.Token,
"/api/console/v1/graphql",
cfg.HTTPTimeoutDuration(),
cmdutil.TokenRefreshOption(cfg, host, hc),
)
_, err = client.Do(
unlinkThirdPartyMutation,
map[string]any{
"input": map[string]any{
"measureId": flagMeasureID,
"thirdPartyId": flagThirdPartyID,
},
},
)
if err != nil {
return err
}
_, _ = fmt.Fprintf(
f.IOStreams.Out,
"Unlinked third party %s from measure %s\n",
flagThirdPartyID,
flagMeasureID,
)
return nil
},
}
cmd.Flags().StringVar(&flagMeasureID, "measure-id", "", "Measure ID (required)")
cmd.Flags().StringVar(&flagThirdPartyID, "third-party-id", "", "Third party ID (required)")
_ = cmd.MarkFlagRequired("measure-id")
_ = cmd.MarkFlagRequired("third-party-id")
return cmd
}