rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use stable files API URLs for vendor logo fields

Browse Source 
CommonThirdParty.logoUrl and TrustCenterReference.logoUrl were
returning expiring S3 presigned URLs, which break if cached or
shared past their TTL.

Replace with stable /api/files/v1/{id} application URLs.
file.Service now generates these via baseurl; a new filesign
package owns presigning for the files/v1 HTTP handler that
does the internal redirect.

Signed-off-by: Ludovic Vielle <ludovic@probo.com>
This commit is contained in:
Ludovic Vielle
2026-06-03 10:21:02 +02:00
parent 383ea5a2d4
commit 6c072a2f7b
14 changed files with 115 additions and 116 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
pkg/file/service.go
View File

@@ -17,51 +17,42 @@ package file
import (
"context"
"fmt"
"time"
"go.gearno.de/kit/pg"
"go.probo.inc/probo/pkg/baseurl"
"go.probo.inc/probo/pkg/coredata"
"go.probo.inc/probo/pkg/filemanager"
"go.probo.inc/probo/pkg/gid"
)
type Service struct {
pg *pg.Client
fileManager *filemanager.Service
pg *pg.Client
baseURL *baseurl.BaseURL
}
func NewService(pgClient *pg.Client, fileManager *filemanager.Service) *Service {
func NewService(pgClient *pg.Client, baseURL *baseurl.BaseURL) *Service {
return &Service{
pg: pgClient,
fileManager: fileManager,
pg: pgClient,
baseURL: baseURL,
}
}
func (s *Service) GetPublicFileURL(
ctx context.Context,
fileID gid.GID,
expiresIn time.Duration,
) (string, error) {
func (s *Service) GenerateFileURL(ctx context.Context, fileID gid.GID) (string, error) {
file := &coredata.File{}
err := s.pg.WithConn(
ctx,
func(ctx context.Context, conn pg.Querier) error {
if err := file.LoadPublicByID(ctx, conn, fileID); err != nil {
return fmt.Errorf("cannot load public file: %w", err)
}
return nil
},
)
err := s.pg.WithConn(ctx, func(ctx context.Context, conn pg.Querier) error {
if err := file.LoadPublicByID(ctx, conn, fileID); err != nil {
return fmt.Errorf("cannot load public file: %w", err)
}
return nil
})
if err != nil {
return "", err
}
presignedURL, err := s.fileManager.GenerateFileUrl(ctx, file, expiresIn)
url, err := s.baseURL.AppendPath("/api/files/v1/" + fileID.String()).String()
if err != nil {
return "", fmt.Errorf("cannot generate file URL: %w", err)
return "", fmt.Errorf("cannot build file URL: %w", err)
}
return presignedURL, nil
return url, nil
}