rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace third-party owners with administrators
Some checks failed
github / Analyze (go) (push) Has been cancelled
Details
github / Analyze (actions) (push) Has been cancelled
Details
github / Analyze (javascript-typescript) (push) Has been cancelled
Details
make / build-apps (push) Has been cancelled
Details
make / probod binary (darwin/amd64) (push) Has been cancelled
Details
make / probod binary (freebsd/amd64) (push) Has been cancelled
Details
make / probod binary (linux/amd64) (push) Has been cancelled
Details
make / probod binary (openbsd/amd64) (push) Has been cancelled
Details
make / probod binary (windows/amd64) (push) Has been cancelled
Details
make / probod binary (darwin/arm64) (push) Has been cancelled
Details
make / probod binary (freebsd/arm64) (push) Has been cancelled
Details
make / probod binary (linux/arm64) (push) Has been cancelled
Details
make / probod binary (openbsd/arm64) (push) Has been cancelled
Details
make / probo-agent (darwin/amd64) (push) Has been cancelled
Details
make / probo-agent (freebsd/amd64) (push) Has been cancelled
Details
make / probo-agent (linux/amd64) (push) Has been cancelled
Details
make / probo-agent (windows/amd64) (push) Has been cancelled
Details
make / probo-agent (darwin/arm64) (push) Has been cancelled
Details
make / probo-agent (freebsd/arm64) (push) Has been cancelled
Details
make / probo-agent (linux/arm64) (push) Has been cancelled
Details
make / probo-agent (windows/arm64) (push) Has been cancelled
Details
make / docker (amd64) (push) Has been cancelled
Details
make / docker (arm64) (push) Has been cancelled
Details
make / snapshot-scan (push) Has been cancelled
Details
make / build-probod (push) Has been cancelled
Details
make / build-probo-agent (push) Has been cancelled
Details
make / lint-go (push) Has been cancelled
Details
make / lint-js (push) Has been cancelled
Details
make / lint-swift (push) Has been cancelled
Details
make / lint-shell (push) Has been cancelled
Details
make / test (push) Has been cancelled
Details
make / test-e2e (push) Has been cancelled
Details
trufflehog / scan (push) Has been cancelled
Details

Browse Source 
Migrate business and security owners into a shared administrators list across GraphQL, MCP, CLI, n8n, and the console.

Signed-off-by: Sacha Al Himdani <sacha@probo.com>
This commit is contained in:
Sacha Al Himdani
2026-07-27 12:24:43 +02:00
parent 084726dbad
commit 6a4f124adb
31 changed files with 808 additions and 601 deletions
Download Patch File Download Diff File Expand all files Collapse all files

80
pkg/server/api/console/v1/dataloader/dataloader.go
View File

@@ -58,21 +58,22 @@ type (
}
Loaders struct {
Organization *dataloadgen.Loader[gid.GID, *coredata.Organization]
Framework *dataloadgen.Loader[gid.GID, *coredata.Framework]
Control *dataloadgen.Loader[gid.GID, *coredata.Control]
ThirdParty *dataloadgen.Loader[gid.GID, *coredata.ThirdParty]
Document *dataloadgen.Loader[gid.GID, *coredata.Document]
Profile *dataloadgen.Loader[gid.GID, *coredata.MembershipProfile]
Risk *dataloadgen.Loader[gid.GID, *coredata.Risk]
Measure *dataloadgen.Loader[gid.GID, *coredata.Measure]
Task *dataloadgen.Loader[gid.GID, *coredata.Task]
File *dataloadgen.Loader[gid.GID, *coredata.File]
CookieBanner *dataloadgen.Loader[gid.GID, *coredata.CookieBanner]
CookieCategory *dataloadgen.Loader[gid.GID, *coredata.CookieCategory]
CommonTrackerPattern *dataloadgen.Loader[gid.GID, *coredata.CommonTrackerPattern]
CommonThirdParty *dataloadgen.Loader[gid.GID, *coredata.CommonThirdParty]
Authorize *dataloadgen.Loader[AuthorizeKey, AuthorizeResult]
Organization *dataloadgen.Loader[gid.GID, *coredata.Organization]
Framework *dataloadgen.Loader[gid.GID, *coredata.Framework]
Control *dataloadgen.Loader[gid.GID, *coredata.Control]
ThirdParty *dataloadgen.Loader[gid.GID, *coredata.ThirdParty]
Document *dataloadgen.Loader[gid.GID, *coredata.Document]
Profile *dataloadgen.Loader[gid.GID, *coredata.MembershipProfile]
Risk *dataloadgen.Loader[gid.GID, *coredata.Risk]
Measure *dataloadgen.Loader[gid.GID, *coredata.Measure]
Task *dataloadgen.Loader[gid.GID, *coredata.Task]
File *dataloadgen.Loader[gid.GID, *coredata.File]
CookieBanner *dataloadgen.Loader[gid.GID, *coredata.CookieBanner]
CookieCategory *dataloadgen.Loader[gid.GID, *coredata.CookieCategory]
CommonTrackerPattern *dataloadgen.Loader[gid.GID, *coredata.CommonTrackerPattern]
CommonThirdParty *dataloadgen.Loader[gid.GID, *coredata.CommonThirdParty]
ThirdPartyAdministratorIDs *dataloadgen.Loader[gid.GID, []gid.GID]
Authorize *dataloadgen.Loader[AuthorizeKey, AuthorizeResult]
}
batchFetcher struct {
@@ -109,20 +110,21 @@ func NewMiddleware(proboSvc *probo.Service, iamSvc *iam.Service, cookieBannerSvc
func (f *batchFetcher) newLoaders() *Loaders {
return &Loaders{
Organization: dataloadgen.NewMappedLoader(f.fetchOrganizations),
Framework: dataloadgen.NewMappedLoader(f.fetchFrameworks),
Control: dataloadgen.NewMappedLoader(f.fetchControls),
ThirdParty: dataloadgen.NewMappedLoader(f.fetchThirdParties),
Document: dataloadgen.NewMappedLoader(f.fetchDocuments),
Profile: dataloadgen.NewMappedLoader(f.fetchProfiles),
Risk: dataloadgen.NewMappedLoader(f.fetchRisks),
Measure: dataloadgen.NewMappedLoader(f.fetchMeasures),
Task: dataloadgen.NewMappedLoader(f.fetchTasks),
File: dataloadgen.NewMappedLoader(f.fetchFiles),
CookieBanner: dataloadgen.NewMappedLoader(f.fetchCookieBanners),
CookieCategory: dataloadgen.NewMappedLoader(f.fetchCookieCategories),
CommonTrackerPattern: dataloadgen.NewMappedLoader(f.fetchCommonTrackerPatterns),
CommonThirdParty: dataloadgen.NewMappedLoader(f.fetchCommonThirdParties),
Organization: dataloadgen.NewMappedLoader(f.fetchOrganizations),
Framework: dataloadgen.NewMappedLoader(f.fetchFrameworks),
Control: dataloadgen.NewMappedLoader(f.fetchControls),
ThirdParty: dataloadgen.NewMappedLoader(f.fetchThirdParties),
Document: dataloadgen.NewMappedLoader(f.fetchDocuments),
Profile: dataloadgen.NewMappedLoader(f.fetchProfiles),
Risk: dataloadgen.NewMappedLoader(f.fetchRisks),
Measure: dataloadgen.NewMappedLoader(f.fetchMeasures),
Task: dataloadgen.NewMappedLoader(f.fetchTasks),
File: dataloadgen.NewMappedLoader(f.fetchFiles),
CookieBanner: dataloadgen.NewMappedLoader(f.fetchCookieBanners),
CookieCategory: dataloadgen.NewMappedLoader(f.fetchCookieCategories),
CommonTrackerPattern: dataloadgen.NewMappedLoader(f.fetchCommonTrackerPatterns),
CommonThirdParty: dataloadgen.NewMappedLoader(f.fetchCommonThirdParties),
ThirdPartyAdministratorIDs: dataloadgen.NewMappedLoader(f.fetchThirdPartyAdministratorIDs),
Authorize: dataloadgen.NewMappedLoader(
f.fetchAuthorizes,
dataloadgen.WithoutCache(),
@@ -350,6 +352,26 @@ func (f *batchFetcher) fetchCommonThirdParties(ctx context.Context, keys []gid.G
return result, nil
}
func (f *batchFetcher) fetchThirdPartyAdministratorIDs(ctx context.Context, keys []gid.GID) (map[gid.GID][]gid.GID, error) {
scope := coredata.NewScopeFromObjectID(keys[0])
administratorIDsByThirdPartyID, err := f.probo.ThirdParties.MapAdministratorIDsForThirdPartyIDs(ctx, scope, keys)
if err != nil {
return nil, fmt.Errorf("cannot batch load third party administrator ids: %w", err)
}
result := make(map[gid.GID][]gid.GID, len(keys))
for _, id := range keys {
if ids, ok := administratorIDsByThirdPartyID[id]; ok {
result[id] = ids
} else {
result[id] = []gid.GID{}
}
}
return result, nil
}
// fetchAuthorizes evaluates the batch with a single AuthorizeMulti call and
// surfaces per-key denials via dataloadgen.MappedFetchError. When
// AuthorizeMulti cannot evaluate the batch as a whole (e.g. mixed