Tailor signature certificate email copy for approvals

Store the per-signature email subject as text on the electronic_signatures
row at creation time, mirroring the consent_text pattern. The document
approval service sets "Your approved <Title> - Certificate of Completion";
other callers default to "Your signed <Name> - Certificate of Completion".
The certificate worker uses signature.email_subject as the email subject,
falling back to the default format when the column is empty.

Signed-off-by: Sacha Al Himdani <sacha@getprobo.com>

pkg/esign/completion_certificate_worker.go

@@ -271,7 +271,12 @@ func (h *completionCertificateHandler) generateCertificate(
 		docName = signature.DocumentType.DisplayName()
 	}
 
-	subject, textBody, htmlBody, err := emailPresenter.RenderElectronicSignatureCertificate(ctx, ref.UnrefOrZero(signature.SignerFullName), docName)
+	subject := signature.EmailSubject
+	if subject == "" {
+		subject = fmt.Sprintf("Your signed %s - Certificate of Completion", docName)
+	}
+
+	textBody, htmlBody, err := emailPresenter.RenderElectronicSignatureCertificate(ctx, ref.UnrefOrZero(signature.SignerFullName), docName, subject)
 	if err != nil {
 		return nil, nil, fmt.Errorf("cannot render email: %w", err)
 	}

pkg/esign/service.go

@@ -52,6 +52,7 @@ type (
 		FileID         gid.GID
 		SignerEmail    mail.Addr
 		ConsentText    string // optional; required when DocumentType == OTHER
+		EmailSubject   string
 	}
 
 	AcceptSignatureRequest struct {
@@ -72,6 +73,7 @@ type (
 		SignerIPAddr   string
 		SignerUA       string
 		ConsentText    string
+		EmailSubject   string
 	}
 
 	RecordEventRequest struct {
@@ -161,6 +163,16 @@ func (s *Service) CreateSignature(
 		}
 	}
 
+	emailSubject := req.EmailSubject
+	if emailSubject == "" {
+		docName := req.DocumentType.DisplayName()
+		if req.DocumentName != nil && *req.DocumentName != "" {
+			docName = *req.DocumentName
+		}
+
+		emailSubject = fmt.Sprintf("Your signed %s - Certificate of Completion", docName)
+	}
+
 	now := time.Now()
 	scope := coredata.NewScopeFromObjectID(req.OrganizationID)
 
@@ -180,6 +192,7 @@ func (s *Service) CreateSignature(
 		FileID:         stampedFileID,
 		SignerEmail:    req.SignerEmail.String(),
 		ConsentText:    consentText,
+		EmailSubject:   emailSubject,
 		SealVersion:    1,
 		AttemptCount:   0,
 		MaxAttempts:    10,
@@ -209,6 +222,7 @@ func (s *Service) CreateAndAcceptSignature(
 			FileID:         req.FileID,
 			SignerEmail:    req.SignerEmail,
 			ConsentText:    req.ConsentText,
+			EmailSubject:   req.EmailSubject,
 		},
 	)
 	if err != nil {