Address PR review on data request pages

Require a verified viewer email before creating a rights request and
validate the free-text fields with the same SafeText bounds the console
uses, so this public portal mutation stays safe and bounded.

Move myRightsRequests onto the base Query, drop the now-dead count
loaders, and order the RECTIFICATION enum value before PORTABILITY so
the Postgres sort order matches RightsRequestTypes().

Harden the v2 kit primitives: SegmentedControl keeps equal-width cards
(auto-fill), preserves its selection when the active card is toggled,
and forwards an accessible name; Field associates its label and error
by id/aria instead of wrapping the control in a label. Give the type
group an accessible name, require the name field for non-complaint
types, use a timezone-stable reference year, drop the underreporting
header count, and neutralize the response-deadline copy.

Signed-off-by: Émile Ré <emile@probo.com>

pkg/coredata/migrations/20260717T133746Z.sql

@@ -18,7 +18,9 @@
 -- OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 -- SOFTWARE.
 
-ALTER TYPE rights_request_type ADD VALUE IF NOT EXISTS 'RECTIFICATION';
+-- Insert RECTIFICATION before PORTABILITY so the enum's sort order matches the
+-- canonical RightsRequestTypes() ordering used for type-sorted cursors.
+ALTER TYPE rights_request_type ADD VALUE IF NOT EXISTS 'RECTIFICATION' BEFORE 'PORTABILITY';
 ALTER TYPE rights_request_type ADD VALUE IF NOT EXISTS 'OBJECTION';
 ALTER TYPE rights_request_type ADD VALUE IF NOT EXISTS 'COMPLAINT';
 

pkg/coredata/rights_requests.go

@@ -240,44 +240,6 @@ WHERE
 	return nil
 }
 
-func (rrs *RightsRequests) CountByOrganizationIDAndContact(
-	ctx context.Context,
-	conn pg.Querier,
-	scope Scoper,
-	organizationID gid.GID,
-	contact string,
-) (int, error) {
-	q := `
-SELECT
-	COUNT(id)
-FROM
-	rights_requests
-WHERE
-	%s
-	AND organization_id = @organization_id
-	AND contact = @contact
-`
-
-	q = fmt.Sprintf(q, scope.SQLFragment())
-
-	args := pgx.StrictNamedArgs{
-		"organization_id": organizationID,
-		"contact":         contact,
-	}
-	maps.Copy(args, scope.SQLArguments())
-
-	row := conn.QueryRow(ctx, q, args)
-
-	var count int
-
-	err := row.Scan(&count)
-	if err != nil {
-		return 0, fmt.Errorf("cannot count rights requests: %w", err)
-	}
-
-	return count, nil
-}
-
 func (rrs *RightsRequests) LoadByOrganizationIDAndContact(
 	ctx context.Context,
 	conn pg.Querier,