From 5e619664acc4e05ed19c74fbe788cd7dd1f72a62 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89mile=20R=C3=A9?= Date: Wed, 10 Dec 2025 15:12:40 +0100 Subject: [PATCH] Remove useless go struct MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Émile Ré --- pkg/probo/document_service.go | 16 ++++------------ pkg/server/api/console/v1/v1_resolver.go | 2 +- 2 files changed, 5 insertions(+), 13 deletions(-) diff --git a/pkg/probo/document_service.go b/pkg/probo/document_service.go index fc5c7973c..c0e424bea 100644 --- a/pkg/probo/document_service.go +++ b/pkg/probo/document_service.go @@ -1034,7 +1034,7 @@ func (s *DocumentService) RequestExport( documentIDs []gid.GID, recipientEmail string, recipientName string, - options BulkExportOptions, + options ExportPDFOptions, ) (*coredata.ExportJob, error) { var exportJobID gid.GID exportJob := &coredata.ExportJob{} @@ -1442,12 +1442,6 @@ type ExportPDFOptions struct { WithSignatures bool } -type BulkExportOptions struct { - WithWatermark bool - WatermarkEmail *string - WithSignatures bool -} - func (s *DocumentService) ExportPDF( ctx context.Context, documentVersionID gid.GID, @@ -1512,7 +1506,7 @@ func (s *DocumentService) BuildAndUploadExport(ctx context.Context, exportJobID return fmt.Errorf("cannot get export arguments: %w", err) } - exportOptions := BulkExportOptions{ + exportOptions := ExportPDFOptions{ WithWatermark: exportArgs.WithWatermark, WatermarkEmail: exportArgs.WatermarkEmail, WithSignatures: exportArgs.WithSignatures, @@ -1719,7 +1713,7 @@ func (s *DocumentService) Export( ctx context.Context, documentIDs []gid.GID, file io.Writer, - options BulkExportOptions, + options ExportPDFOptions, ) (err error) { archive := zip.NewWriter(file) defer func() { @@ -1742,8 +1736,6 @@ func (s *DocumentService) Export( return fmt.Errorf("cannot load document version for %q: %w", documentID, err) } - pdfOptions := ExportPDFOptions(options) - exportedPDF, err := exportDocumentPDF( ctx, s.svc, @@ -1751,7 +1743,7 @@ func (s *DocumentService) Export( conn, s.svc.scope, documentVersion.ID, - pdfOptions, + options, ) if err != nil { return fmt.Errorf("cannot export document PDF for %q: %w", documentID, err) diff --git a/pkg/server/api/console/v1/v1_resolver.go b/pkg/server/api/console/v1/v1_resolver.go index c78a096a6..2a1186169 100644 --- a/pkg/server/api/console/v1/v1_resolver.go +++ b/pkg/server/api/console/v1/v1_resolver.go @@ -3406,7 +3406,7 @@ func (r *mutationResolver) BulkExportDocuments(ctx context.Context, input types. user := UserFromContext(ctx) - options := probo.BulkExportOptions{ + options := probo.ExportPDFOptions{ WithWatermark: input.WithWatermark, WithSignatures: input.WithSignatures, WatermarkEmail: input.WatermarkEmail,