Use struct campaign errors with campaign ID in message

Business-layer errors carry the access review campaign GID in Error() and match GraphQL sentinels via Is(). Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Bryan FRIMIN <bryan@frimin.fr>
2026-07-27 13:16:31 +00:00
parent 1422b6d5dd
commit 5dca6bb883
3 changed files with 225 additions and 66 deletions
--- a/pkg/accessreview/errors_test.go
+++ b/pkg/accessreview/errors_test.go
@@ -0,0 +1,88 @@
+// Copyright (c) 2026 Probo Inc <hello@probo.com>.
+//
+// Permission is hereby granted, free of charge, to any person obtaining a copy
+// of this software and associated documentation files (the "Software"), to deal
+// in the Software without restriction, including without limitation the rights
+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+// copies of the Software, and to permit persons to whom the Software is
+// furnished to do so, subject to the following conditions:
+//
+// The above copyright notice and this permission notice shall be included in
+// all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+// SOFTWARE.
+
+package accessreview_test
+
+import (
+	"fmt"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"go.probo.inc/probo/pkg/accessreview"
+	"go.probo.inc/probo/pkg/coredata"
+	"go.probo.inc/probo/pkg/gid"
+)
+
+func TestCampaignClientErrors(t *testing.T) {
+	t.Parallel()
+
+	tenantID := gid.NewTenantID()
+	campaignID := gid.New(tenantID, coredata.AccessReviewCampaignEntityType)
+
+	tests := []struct {
+		name     string
+		err      error
+		wantText string
+		sentinel error
+	}{
+		{
+			name: "missing sources",
+			err:  accessreview.NewCampaignMissingSourcesError(campaignID),
+			wantText: fmt.Sprintf(
+				"access review campaign %q cannot be started: no scope sources configured",
+				campaignID,
+			),
+			sentinel: accessreview.ErrCampaignMissingSources,
+		},
+		{
+			name:     "in progress",
+			err:      accessreview.NewCampaignInProgressError(campaignID),
+			wantText: fmt.Sprintf("access review campaign %q is in progress", campaignID),
+			sentinel: accessreview.ErrCampaignInProgress,
+		},
+		{
+			name:     "pending actions",
+			err:      accessreview.NewCampaignPendingActionsError(campaignID),
+			wantText: fmt.Sprintf("access review campaign %q is pending actions", campaignID),
+			sentinel: accessreview.ErrCampaignPendingActions,
+		},
+		{
+			name:     "completed",
+			err:      accessreview.NewCampaignCompletedError(campaignID),
+			wantText: fmt.Sprintf("access review campaign %q is completed", campaignID),
+			sentinel: accessreview.ErrCampaignCompleted,
+		},
+		{
+			name:     "cancelled",
+			err:      accessreview.NewCampaignCancelledError(campaignID),
+			wantText: fmt.Sprintf("access review campaign %q is cancelled", campaignID),
+			sentinel: accessreview.ErrCampaignCancelled,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
+
+			assert.Equal(t, tt.wantText, tt.err.Error())
+			assert.ErrorIs(t, tt.err, tt.sentinel)
+		})
+	}
+}