rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Move document classification from document to document version

Browse Source 
Classification now lives exclusively on DocumentVersion. The field is
removed from the Document model, all SQL queries, GraphQL Document
type, SignableDocument type, UpdateDocumentInput, and MCP Document
schema.

New documents still accept classification in CreateDocumentInput,
applied to the first version. New drafts inherit classification from
the previous version. PDF generation uses the version classification.

The drawer allows editing classification on draft versions via the
updateDocumentVersion mutation. Classification is read-only on
published versions.

Signed-off-by: Sacha Al Himdani <sacha@getprobo.com>
This commit is contained in:
Sacha Al Himdani
2026-03-27 16:04:38 +01:00
parent 851e585b9b
commit 5d6d0bdd7f
16 changed files with 155 additions and 151 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
pkg/coredata/document.go
View File

@@ -30,18 +30,17 @@ import (
type (
Document struct {
ID gid.GID `db:"id"`
OrganizationID gid.GID `db:"organization_id"`
Title string `db:"title"`
DocumentType DocumentType `db:"document_type"`
Classification DocumentClassification `db:"classification"`
CurrentPublishedMajor *int `db:"current_published_major"`
CurrentPublishedMinor *int `db:"current_published_minor"`
TrustCenterVisibility TrustCenterVisibility `db:"trust_center_visibility"`
Status DocumentStatus `db:"status"`
ArchivedAt *time.Time `db:"archived_at"`
CreatedAt time.Time `db:"created_at"`
UpdatedAt time.Time `db:"updated_at"`
ID gid.GID `db:"id"`
OrganizationID gid.GID `db:"organization_id"`
Title string `db:"title"`
DocumentType DocumentType `db:"document_type"`
CurrentPublishedMajor *int `db:"current_published_major"`
CurrentPublishedMinor *int `db:"current_published_minor"`
TrustCenterVisibility TrustCenterVisibility `db:"trust_center_visibility"`
Status DocumentStatus `db:"status"`
ArchivedAt *time.Time `db:"archived_at"`
CreatedAt time.Time `db:"created_at"`
UpdatedAt time.Time `db:"updated_at"`
}
Documents []*Document
@@ -128,7 +127,6 @@ SELECT
organization_id,
title,
document_type,
classification,
current_published_major,
current_published_minor,
trust_center_visibility,
@@ -182,7 +180,6 @@ SELECT
organization_id,
title,
document_type,
classification,
current_published_major,
current_published_minor,
trust_center_visibility,
@@ -237,7 +234,6 @@ SELECT
organization_id,
title,
document_type,
classification,
current_published_major,
current_published_minor,
trust_center_visibility,
@@ -321,7 +317,6 @@ SELECT
organization_id,
title,
document_type,
classification,
current_published_major,
current_published_minor,
trust_center_visibility,
@@ -374,7 +369,6 @@ SELECT
organization_id,
title,
document_type,
classification,
current_published_major,
current_published_minor,
trust_center_visibility,
@@ -441,7 +435,6 @@ SELECT
organization_id,
COALESCE(published_title, title) AS title,
document_type,
classification,
current_published_major,
current_published_minor,
trust_center_visibility,
@@ -491,7 +484,6 @@ INSERT INTO
organization_id,
title,
document_type,
classification,
current_published_major,
current_published_minor,
trust_center_visibility,
@@ -506,7 +498,6 @@ VALUES (
@organization_id,
@title,
@document_type,
@classification,
@current_published_major,
@current_published_minor,
@trust_center_visibility,
@@ -523,7 +514,6 @@ VALUES (
"organization_id": p.OrganizationID,
"title": p.Title,
"document_type": p.DocumentType,
"classification": p.Classification,
"current_published_major": p.CurrentPublishedMajor,
"current_published_minor": p.CurrentPublishedMinor,
"trust_center_visibility": p.TrustCenterVisibility,
@@ -586,7 +576,6 @@ SET
current_published_major = @current_published_major,
current_published_minor = @current_published_minor,
document_type = @document_type,
classification = @classification,
trust_center_visibility = @trust_center_visibility,
status = @status,
archived_at = @archived_at,
@@ -605,7 +594,6 @@ WHERE
"current_published_major": p.CurrentPublishedMajor,
"current_published_minor": p.CurrentPublishedMinor,
"document_type": p.DocumentType,
"classification": p.Classification,
"trust_center_visibility": p.TrustCenterVisibility,
"status": p.Status,
"archived_at": p.ArchivedAt,
@@ -678,7 +666,6 @@ SELECT
scoped_documents.organization_id,
scoped_documents.title,
scoped_documents.document_type,
scoped_documents.classification,
scoped_documents.current_published_major,
scoped_documents.current_published_minor,
scoped_documents.trust_center_visibility,
@@ -770,7 +757,6 @@ SELECT
scoped_documents.organization_id,
scoped_documents.title,
scoped_documents.document_type,
scoped_documents.classification,
scoped_documents.current_published_major,
scoped_documents.current_published_minor,
scoped_documents.trust_center_visibility,

2
pkg/coredata/migrations/20260328T120000Z.sql Normal file
View File

@@ -0,0 +1,2 @@
-- TODO: drop the classification column from documents.
ALTER TABLE documents ALTER COLUMN classification SET DEFAULT 'SECRET';