rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add reviewdog to post lint errors as PR comments

Browse Source 
Use reviewdog in the CI lint job so golangci-lint and eslint
failures appear as inline comments on pull request files instead
of only in job logs.

Signed-off-by: Bryan Frimin <bryan@getprobo.com>
This commit is contained in:
Bryan Frimin
2026-03-16 00:36:20 +01:00
parent 6a77d42dd6
commit 5c22789624
1 changed files with 27 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
.github/workflows/make.yaml vendored
View File

@@ -125,6 +125,8 @@ jobs:
runs-on: "ubuntu-22.04" runs-on: "ubuntu-22.04"
permissions: permissions:
contents: "read" contents: "read"
pull-requests: "write"
checks: "write"
steps: steps:
- uses: "actions/checkout@v6" - uses: "actions/checkout@v6"
with: with:
@@ -140,13 +142,37 @@ jobs:
- uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20 # v9.2.0 - uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20 # v9.2.0
with: with:
install-only: true install-only: true
- uses: reviewdog/action-setup@d8a7baabd7f3e8544ee4dbde3ee41d0011c3a93f # v1.5.0
- run: "npm i -g npm@11.8.0" - run: "npm i -g npm@11.8.0"
- run: "npm ci" - run: "npm ci"
- uses: "actions/download-artifact@v6" - uses: "actions/download-artifact@v6"
with: with:
name: "build-artifacts" name: "build-artifacts"
- run: "chmod +x bin/probod" - run: "chmod +x bin/probod"
- run: "make lint" - name: "Run go vet"
run: "go vet ./..."
- name: "Run golangci-lint"
env:
REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
if [ "${{ github.event_name }}" = "pull_request" ]; then
golangci-lint run --out-format=line-number ./... 2>&1 | \
reviewdog -f=golangci-lint -reporter=github-pr-review -filter-mode=nofilter -fail-level=error -name="golangci-lint"
else
golangci-lint run ./...
fi
- name: "Run eslint"
env:
REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
if [ "${{ github.event_name }}" = "pull_request" ]; then
for dir in apps/console apps/trust packages/ui packages/eslint-config packages/n8n-node; do
(cd "$dir" && npx eslint . --concurrency 4 --format stylish 2>/dev/null) | \
reviewdog -f=eslint -reporter=github-pr-review -filter-mode=nofilter -fail-level=error -name="eslint ($dir)"
done
else
npm run lint
fi
test: test:
name: "test" name: "test"