rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Allow closing failed access reviews

Browse Source 
Signed-off-by: Cursor Agent <cursoragent@cursor.com>

Co-authored-by: Bryan FRIMIN <bryan@frimin.fr>
This commit is contained in:
Cursor Agent
2026-06-26 09:34:40 +00:00
committed by Bryan Frimin
parent bf255b198c
commit 5bf8727076
1 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
apps/console/src/pages/organizations/access-reviews/campaigns/CampaignDetailPage.tsx
View File

@@ -148,6 +148,7 @@ export const campaignDetailPageQuery = graphql`
id
name
status
pendingEntryCount
canDelete: permission(action: "access-review:campaign:delete")
sources {
id
@@ -248,13 +249,7 @@ export default function CampaignDetailPage({ queryRef }: Props) {
const [deleteCampaign, isDeleting]
= useMutation<CampaignDetailPageDeleteMutation>(deleteCampaignMutation);
const allDecided = campaign.sources.length > 0
&& campaign.sources.every(source =>
source.entries
&& source.entries.edges.length > 0
&& source.entries.edges.every(edge => edge.node.decision !== "PENDING")
&& !source.entries.pageInfo.hasNextPage,
);
const canComplete = campaign.pendingEntryCount === 0;
const handleStart = () => {
startCampaign({
@@ -425,7 +420,7 @@ export default function CampaignDetailPage({ queryRef }: Props) {
{isPendingActions && (
<Button
onClick={handleComplete}
disabled={!allDecided || isClosing}
disabled={!canComplete || isClosing}
>
{isClosing ? __("Completing...") : __("Complete campaign")}
</Button>