rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Align risk severity across views

Browse Source 
Use the shared getSeverity helper from @probo/helpers in SeverityBadge
so the list view displays the same labels (Low/High/Critical) and
thresholds (0/5/15) as the detail view. Also fix the RisksChart legend
and getLevel thresholds to match.

Signed-off-by: Sacha Al Himdani <sacha@getprobo.com>
This commit is contained in:
Sacha Al Himdani
2026-04-14 16:45:39 +02:00
parent 16b1a48c55
commit 58c2415275
2 changed files with 5 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
packages/ui/src/Molecules/Badge/SeverityBadge.tsx
View File

@@ -12,6 +12,7 @@
// OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR // OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
// PERFORMANCE OF THIS SOFTWARE. // PERFORMANCE OF THIS SOFTWARE.
import { getSeverity } from "@probo/helpers";
import { useTranslate } from "@probo/i18n"; import { useTranslate } from "@probo/i18n";
import { Badge } from "../../Atoms/Badge/Badge"; import { Badge } from "../../Atoms/Badge/Badge";
@@ -20,26 +21,8 @@ type Props = {
score: number; score: number;
}; };
const badgeVariant = (score: number) => {
if (score >= 15) {
return "danger";
}
if (score > 6) {
return "warning";
}
return "success";
};
export function SeverityBadge({ score }: Props) { export function SeverityBadge({ score }: Props) {
const { __ } = useTranslate(); const { __ } = useTranslate();
const label = () => { const severity = getSeverity(__, score);
if (score >= 15) { return <Badge variant={severity?.variant}>{severity?.label}</Badge>;
return __("High");
}
if (score > 6) {
return __("Medium");
}
return __("Low");
};
return <Badge variant={badgeVariant(score)}>{label()}</Badge>;
} }

4
packages/ui/src/Molecules/Risks/RisksChart.tsx
View File

@@ -47,7 +47,7 @@ const getLevel = (score: number): 0 | 1 | 2 => {
if (score >= 15) { if (score >= 15) {
return 2; return 2;
} }
if (score > 6) { if (score >= 5) {
return 1; return 1;
} }
return 0; return 0;
@@ -62,7 +62,7 @@ const cellKey = (impact: number, likelihood: number) =>
export function RisksChart({ organizationId, type, risks }: Props) { export function RisksChart({ organizationId, type, risks }: Props) {
const { __ } = useTranslate(); const { __ } = useTranslate();
const legend = [__("Low"), __("Medium"), __("High")]; const legend = [__("Low"), __("High"), __("Critical")];
const impacts = getRiskImpacts(__).reverse(); const impacts = getRiskImpacts(__).reverse();
const likelihoods = getRiskLikelihoods(__); const likelihoods = getRiskLikelihoods(__);