Add opt-in shell lint and format targets

Introduce make lint-shell / fmt-shell with shellcheck and
shfmt (-i 2 -ci -bn), normalize first-party scripts, and
document the new targets. Keep them out of make lint / fmt.

Signed-off-by: Ludovic Vielle <ludovic@probo.com>

cmd/probo-agent/installer/macos/uninstall.sh

@@ -26,94 +26,93 @@ PKG_ID="com.probo.agent"
 LSREGISTER="/System/Library/Frameworks/CoreServices.framework/Frameworks/LaunchServices.framework/Support/lsregister"
 
 log() {
-    printf '%s\n' "$*"
+  printf '%s\n' "$*"
 }
 
 die() {
-    printf 'error: %s\n' "$*" >&2
-    exit 1
+  printf 'error: %s\n' "$*" >&2
+  exit 1
 }
 
 require_root() {
-    if [ "$(id -u)" -ne 0 ]; then
-        die "must run as root (try: sudo make -C cmd/probo-agent uninstall)"
-    fi
+  if [ "$(id -u)" -ne 0 ]; then
+    die "must run as root (try: sudo make -C cmd/probo-agent uninstall)"
+  fi
 }
 
 bootout_system_plist() {
-    local plist="$1"
-    if [ -f "${plist}" ]; then
-        launchctl bootout system "${plist}" 2>/dev/null || true
-        log "Booted out ${plist}"
-    fi
+  local plist="$1"
+  if [ -f "${plist}" ]; then
+    launchctl bootout system "${plist}" 2>/dev/null || true
+    log "Booted out ${plist}"
+  fi
 }
 
 bootout_tray_for_user() {
-    local username="$1"
-    local user_uid
+  local username="$1"
+  local user_uid
 
-    if [ -z "${username}" ] || \
-       [ "${username}" = "root" ] || \
-       [ "${username}" = "loginwindow" ]; then
-        return 0
-    fi
+  if [ -z "${username}" ] \
+    || [ "${username}" = "root" ] \
+    || [ "${username}" = "loginwindow" ]; then
+    return 0
+  fi
 
-    user_uid="$(id -u "${username}" 2>/dev/null || true)"
-    if [ -z "${user_uid}" ]; then
-        return 0
-    fi
+  user_uid="$(id -u "${username}" 2>/dev/null || true)"
+  if [ -z "${user_uid}" ]; then
+    return 0
+  fi
 
-    launchctl bootout "gui/${user_uid}/${TRAY_LABEL}" 2>/dev/null || true
+  launchctl bootout "gui/${user_uid}/${TRAY_LABEL}" 2>/dev/null || true
 }
 
 unregister_apps() {
-    local path
-    for path in \
-        "/Applications/Probo Agent.app" \
-        "/Applications/Probo Agent.localized/Probo Agent.app"
-    do
-        if [ -d "${path}" ] && [ -x "${LSREGISTER}" ]; then
-            "${LSREGISTER}" -u "${path}" 2>/dev/null || true
-            log "Unregistered Launch Services entry for ${path}"
-        fi
-    done
+  local path
+  for path in \
+    "/Applications/Probo Agent.app" \
+    "/Applications/Probo Agent.localized/Probo Agent.app"; do
+    if [ -d "${path}" ] && [ -x "${LSREGISTER}" ]; then
+      "${LSREGISTER}" -u "${path}" 2>/dev/null || true
+      log "Unregistered Launch Services entry for ${path}"
+    fi
+  done
 }
 
 kill_leftovers() {
-    # Best-effort; deleted-but-running binaries otherwise keep claiming probo://.
-    pkill -x probo-agent-url-handler 2>/dev/null || true
-    pkill -f '/usr/local/bin/probo-agent tray' 2>/dev/null || true
-    pkill -f '/Library/PrivilegedHelperTools/com.probo.agent.helper' 2>/dev/null || true
-    # Agent daemon may still be running after plist bootout races.
-    pkill -x probo-agent 2>/dev/null || true
+  # Best-effort; deleted-but-running binaries otherwise keep claiming probo://.
+  pkill -x probo-agent-url-handler 2>/dev/null || true
+  pkill -f '/usr/local/bin/probo-agent tray' 2>/dev/null || true
+  pkill -f '/Library/PrivilegedHelperTools/com.probo.agent.helper' 2>/dev/null || true
+  # Agent daemon may still be running after plist bootout races.
+  pkill -x probo-agent 2>/dev/null || true
 }
 
 require_root
 
 if [ "$(uname -s)" != "Darwin" ]; then
-    die "this uninstall script is macOS-only"
+  die "this uninstall script is macOS-only"
 fi
 
 log "=== probo-agent macOS uninstall $(date -u +%Y-%m-%dT%H:%M:%SZ) ==="
 
 # Prefer the agent's own uninstall for service/tray/state when present.
 if [ -x "${BINARY}" ]; then
-    if "${BINARY}" uninstall; then
-        log "Ran: ${BINARY} uninstall"
-    else
-        log "warning: ${BINARY} uninstall failed; continuing with manual cleanup"
-    fi
+  if "${BINARY}" uninstall; then
+    log "Ran: ${BINARY} uninstall"
+  else
+    log "warning: ${BINARY} uninstall failed; continuing with manual cleanup"
+  fi
 else
-    log "Binary not found at ${BINARY}; skipping probo-agent uninstall"
+  log "Binary not found at ${BINARY}; skipping probo-agent uninstall"
 fi
 
 seen_users=" "
 for username in $(users 2>/dev/null || true); do
-    case "${seen_users}" in
-        *" ${username} "*) continue ;;
-    esac
-    seen_users="${seen_users}${username} "
-    bootout_tray_for_user "${username}"
+  case "${seen_users}" in
+    *" ${username} "*) continue ;;
+  esac
+  seen_users="${seen_users}${username} "
+  bootout_tray_for_user "${username}"
 done
 bootout_tray_for_user "$(stat -f "%Su" /dev/console 2>/dev/null || true)"
 
@@ -127,23 +126,23 @@ log "Removed LaunchDaemon / LaunchAgent / helper files (if present)"
 
 unregister_apps
 rm -rf \
-    "/Applications/Probo Agent.app" \
-    "/Applications/Probo Agent.localized"
+  "/Applications/Probo Agent.app" \
+  "/Applications/Probo Agent.localized"
 log "Removed Probo Agent.app (if present)"
 
 rm -f "${BINARY}"
 rm -rf "${STATE_DIR}" "${RUN_DIR}"
 rm -f \
-    /var/log/probo-agent.log \
-    /var/log/probo-agent-install.log \
-    /tmp/probo-agent.conf
+  /var/log/probo-agent.log \
+  /var/log/probo-agent-install.log \
+  /tmp/probo-agent.conf
 log "Removed binary, state, run dir, logs, and staged conf (if present)"
 
 if pkgutil --pkg-info "${PKG_ID}" >/dev/null 2>&1; then
-    if ! pkgutil --forget "${PKG_ID}" >/dev/null; then
-        die "failed to forget PKG receipt ${PKG_ID}"
-    fi
-    log "Forgot PKG receipt ${PKG_ID}"
+  if ! pkgutil --forget "${PKG_ID}" >/dev/null; then
+    die "failed to forget PKG receipt ${PKG_ID}"
+  fi
+  log "Forgot PKG receipt ${PKG_ID}"
 fi
 
 log "=== uninstall done ==="