rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix 5xx on profile request

Browse Source 
Signed-off-by: Bryan Frimin <bryan@getprobo.com>
This commit is contained in:
Bryan Frimin
2026-01-18 09:12:08 -08:00
parent f57c306b05
commit 56a2073547
2 changed files with 5 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/server/api/connect/v1/types/membership.go
View File

@@ -69,9 +69,6 @@ func NewMembership(membership *coredata.Membership) *Membership {
Organization: &Organization{ Organization: &Organization{
ID: membership.OrganizationID, ID: membership.OrganizationID,
}, },
Profile: &MembershipProfile{
ID: membership.ID,
},
Role: membership.Role, Role: membership.Role,
Source: membership.Source, Source: membership.Source,
State: membership.State, State: membership.State,

14
pkg/server/api/connect/v1/v1_resolver.go
View File

@@ -246,15 +246,7 @@ func (r *membershipResolver) Identity(ctx context.Context, obj *types.Membership
// Profile is the resolver for the profile field. // Profile is the resolver for the profile field.
func (r *membershipResolver) Profile(ctx context.Context, obj *types.Membership) (*types.MembershipProfile, error) { func (r *membershipResolver) Profile(ctx context.Context, obj *types.Membership) (*types.MembershipProfile, error) {
if err := r.authorize(ctx, obj.Profile.ID, iam.ActionMembershipProfileGet); err != nil { // TODO: PorfileID must leave on membership to allow perform the ACL lookup first and load after.
return nil, err
}
if gqlutils.OnlyIDSelected(ctx) {
return &types.MembershipProfile{
ID: obj.Profile.ID,
}, nil
}
profile, err := r.iam.AccountService.GetProfileForMembership(ctx, obj.ID) profile, err := r.iam.AccountService.GetProfileForMembership(ctx, obj.ID)
if err != nil { if err != nil {
@@ -267,6 +259,10 @@ func (r *membershipResolver) Profile(ctx context.Context, obj *types.Membership)
return nil, gqlutils.Internal(ctx) return nil, gqlutils.Internal(ctx)
} }
if err := r.authorize(ctx, profile.ID, iam.ActionMembershipProfileGet); err != nil {
return nil, err
}
return types.NewMembershipProfile(profile), nil return types.NewMembershipProfile(profile), nil
} }