From 51ff8ecc14305f09b7cca2bdf97fbb62576733dd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Aur=C3=A9lien=20Sibiril?=
 <81782+aureliensibiril@users.noreply.github.com>
Date: Mon, 11 May 2026 11:55:34 +0200
Subject: [PATCH] Use @deleteEdge on campaign detail delete mutation
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

@deleteRecord wiped the campaign from the Relay store but left the
cached AccessReviewCampaignsTabQuery connection holding an edge
pointing to the now-missing record. Re-opening the access-reviews
tab made Relay surface a missing-data error and the org error
boundary rendered "Unexpected error :(".

Switch to @deleteEdge with the campaigns connection id so the edge
is removed alongside the deletion, matching the pattern already used
by audit and statement-of-applicability detail pages.

Signed-off-by: Aurélien Sibiril <81782+aureliensibiril@users.noreply.github.com>
---
 .../access-reviews/campaigns/CampaignDetailPage.tsx  | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/apps/console/src/pages/organizations/access-reviews/campaigns/CampaignDetailPage.tsx b/apps/console/src/pages/organizations/access-reviews/campaigns/CampaignDetailPage.tsx
index 8773a659b..b4cf0c973 100644
--- a/apps/console/src/pages/organizations/access-reviews/campaigns/CampaignDetailPage.tsx
+++ b/apps/console/src/pages/organizations/access-reviews/campaigns/CampaignDetailPage.tsx
@@ -45,7 +45,7 @@ import * as Popover from "@radix-ui/react-popover";
 import { useEffect, useMemo, useRef, useState } from "react";
 import { type PreloadedQuery, useMutation, usePreloadedQuery, useRelayEnvironment } from "react-relay";
 import { useNavigate } from "react-router";
-import { fetchQuery, graphql } from "relay-runtime";
+import { ConnectionHandler, fetchQuery, graphql } from "relay-runtime";
 
 import type { AccessEntryDecision, CampaignDetailPageBulkDecisionMutation } from "#/__generated__/core/CampaignDetailPageBulkDecisionMutation.graphql";
 import type { AccessEntryFlag, CampaignDetailPageBulkFlagMutation } from "#/__generated__/core/CampaignDetailPageBulkFlagMutation.graphql";
@@ -101,9 +101,10 @@ const closeCampaignMutation = graphql`
 const deleteCampaignMutation = graphql`
   mutation CampaignDetailPageDeleteMutation(
     $input: DeleteAccessReviewCampaignInput!
+    $connections: [ID!]!
   ) {
     deleteAccessReviewCampaign(input: $input) {
-      deletedAccessReviewCampaignId @deleteRecord
+      deletedAccessReviewCampaignId @deleteEdge(connections: $connections)
     }
   }
 `;
@@ -283,12 +284,19 @@ export default function CampaignDetailPage({ queryRef }: Props) {
   };
 
   const handleDelete = () => {
+    const connections = [
+      ConnectionHandler.getConnectionID(
+        organizationId,
+        "AccessReviewCampaignsTab_accessReviewCampaigns",
+      ),
+    ];
     confirm(
       () =>
         new Promise<void>((resolve) => {
           deleteCampaign({
             variables: {
               input: { accessReviewCampaignId: campaign.id },
+              connections,
             },
             onCompleted(_, errors) {
               if (errors?.length) {