Better handle falsy values in Select & GraphQL cells

Signed-off-by: Émile Ré <nemile.re@gmail.com>
This commit is contained in:
Émile Ré
2025-12-02 10:47:40 +04:00
parent 57e267afe0
commit 519dd716b3
5 changed files with 17 additions and 13 deletions

View File

@@ -27,13 +27,13 @@ export const selectCell = tv({
},
});
export function SelectCell<T>(props: Props<T>) {
export function SelectCell<T extends NonNullable<unknown>>(props: Props<T>) {
const [value, setValue, valueRef] = useStateWithRef<T | T[]>(
props.defaultValue,
);
const cellRef = useEditableCellRef();
const { __ } = useTranslate();
const filteredValue = Array.isArray(value) ? value.filter(Boolean) : value ? [value] : [];
const filteredValue = Array.isArray(value) ? value.filter(v => v !== undefined) : value ? [value] : [];
const usedKeys = new Set<string>(filteredValue.map(getKey).filter(Boolean) as string[]);
const { onUpdate } = useEditableRowContext();
@@ -103,12 +103,12 @@ export function SelectCell<T>(props: Props<T>) {
);
}
export function SelectValue<T>(props: {
export function SelectValue<T extends NonNullable<unknown>>(props: {
itemRenderer: Props<T>["itemRenderer"];
onValueChange?: (value: T | T[]) => void;
value: T | T[] | undefined;
}) {
if (!props.value) {
if (props.value === undefined) {
return "";
}
if (!Array.isArray(props.value)) {

View File

@@ -24,7 +24,7 @@ export function TextCell(props: Props) {
if (props.required && inputValue === "") {
return;
}
if (inputValue !== props.defaultValue) {
if (inputValue !== value) {
setValue(inputValue);
onUpdate(props.name, inputValue);
}