rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Introduce access-review source snapshot and normalize naming

Browse Source 
Decouple each campaign from the live access-review sources it was started
with by introducing a per-campaign source snapshot table
(access_review_campaign_sources). The snapshot captures the source name,
category, and connector at start time, so a review remains coherent even
after the underlying source is edited or deleted. Fetch tracking becomes
an append-only log (access_review_campaign_source_fetch_attempts) that
preserves every attempt with its own status and error rather than
overwriting a single row.

Rename the shared access-review tables and enums to use a consistent
access_review_ prefix throughout:

  access_entries          → access_review_entries
  access_sources          → access_review_sources
  access_source_category  → access_review_source_category
  access_entry_*          → access_review_entry_*

The same rename propagates to every coredata type, service, GraphQL
schema, MCP specification, CLI command, frontend component, and e2e test.
The accessreview package gains dedicated actions.go and policies.go files
for its own IAM policy set, mirroring the agentrun package pattern.

Signed-off-by: Bryan Frimin <bryan@probo.com>
This commit is contained in:
Bryan Frimin
2026-06-11 15:58:30 +02:00
parent 8a53e0ec1c
commit 4b64e59da4
146 changed files with 4795 additions and 4069 deletions
Download Patch File Download Diff File Expand all files Collapse all files

78
pkg/cmd/access-review/entry/list/list.go
View File

@@ -29,9 +29,9 @@ query(
$id: ID!,
$first: Int,
$after: CursorKey,
$orderBy: AccessEntryOrder,
$accessSourceId: ID,
$filter: AccessEntryFilter
$orderBy: AccessReviewEntryOrder,
$campaignSourceId: ID,
$filter: AccessReviewEntryFilter
) {
node(id: $id) {
__typename
@@ -40,7 +40,7 @@ query(
first: $first,
after: $after,
orderBy: $orderBy,
accessSourceId: $accessSourceId,
campaignSourceId: $campaignSourceId,
filter: $filter
) {
totalCount
@@ -81,24 +81,24 @@ query(
`
type entryNode struct {
ID string `json:"id"`
Email string `json:"email"`
FullName string `json:"fullName"`
Role string `json:"role"`
JobTitle string `json:"jobTitle"`
IsAdmin bool `json:"isAdmin"`
Active *bool `json:"active"`
MfaStatus string `json:"mfaStatus"`
AuthMethod string `json:"authMethod"`
AccountType string `json:"accountType"`
LastLogin *string `json:"lastLogin"`
ExternalID string `json:"externalId"`
IncrementalTag string `json:"incrementalTag"`
Flags []string `json:"flags"`
FlagReasons []string `json:"flagReasons"`
Decision string `json:"decision"`
DecisionNote *string `json:"decisionNote"`
AccessSource struct {
ID string `json:"id"`
Email string `json:"email"`
FullName string `json:"fullName"`
Role string `json:"role"`
JobTitle string `json:"jobTitle"`
IsAdmin bool `json:"isAdmin"`
Active *bool `json:"active"`
MfaStatus string `json:"mfaStatus"`
AuthMethod string `json:"authMethod"`
AccountType string `json:"accountType"`
LastLogin *string `json:"lastLogin"`
ExternalID string `json:"externalId"`
IncrementalTag string `json:"incrementalTag"`
Flags []string `json:"flags"`
FlagReasons []string `json:"flagReasons"`
Decision string `json:"decision"`
DecisionNote *string `json:"decisionNote"`
AccessReviewSource struct {
ID string `json:"id"`
Name string `json:"name"`
} `json:"accessSource"`
@@ -107,18 +107,18 @@ type entryNode struct {
func NewCmdList(f *cmdutil.Factory) *cobra.Command {
var (
flagLimit int
flagOrderBy string
flagOrderDir string
flagSourceID string
flagDecision string
flagFlag string
flagIncTag string
flagIsAdmin *bool
flagActive *bool
flagAuthMethod string
flagAccountType string
flagOutput *string
flagLimit int
flagOrderBy string
flagOrderDir string
flagCampaignSourceID string
flagDecision string
flagFlag string
flagIncTag string
flagIsAdmin *bool
flagActive *bool
flagAuthMethod string
flagAccountType string
flagOutput *string
)
cmd := &cobra.Command{
@@ -129,7 +129,7 @@ func NewCmdList(f *cmdutil.Factory) *cobra.Command {
prb access-review entry list <campaign-id>
# List entries for a specific source
prb access-review entry list <campaign-id> --source-id <source-id>
prb access-review entry list <campaign-id> --campaign-source-id <source-id>
# List only pending entries
prb access-review entry list <campaign-id> --decision PENDING
@@ -178,8 +178,8 @@ func NewCmdList(f *cmdutil.Factory) *cobra.Command {
}
}
if flagSourceID != "" {
variables["accessSourceId"] = flagSourceID
if flagCampaignSourceID != "" {
variables["campaignSourceId"] = flagCampaignSourceID
}
filter := map[string]any{}
@@ -326,7 +326,7 @@ func NewCmdList(f *cmdutil.Factory) *cobra.Command {
e.ID,
e.Email,
e.FullName,
e.AccessSource.Name,
e.AccessReviewSource.Name,
e.Decision,
strings.Join(e.Flags, ","),
admin,
@@ -354,7 +354,7 @@ func NewCmdList(f *cmdutil.Factory) *cobra.Command {
cmd.Flags().IntVarP(&flagLimit, "limit", "L", 30, "Maximum number of entries to list")
cmd.Flags().StringVar(&flagOrderBy, "order-by", "", "Order by field (CREATED_AT)")
cmd.Flags().StringVar(&flagOrderDir, "order-direction", "DESC", "Sort direction (ASC, DESC)")
cmd.Flags().StringVar(&flagSourceID, "source-id", "", "Filter by access source ID")
cmd.Flags().StringVar(&flagCampaignSourceID, "source-id", "", "Filter by access source ID")
cmd.Flags().StringVar(&flagDecision, "decision", "", "Filter by decision (PENDING, APPROVED, REVOKE, DEFER, ESCALATE)")
cmd.Flags().StringVar(&flagFlag, "flag", "", "Filter by flag (NONE, ORPHANED, INACTIVE, EXCESSIVE, ROLE_MISMATCH, NEW)")
cmd.Flags().StringVar(&flagIncTag, "incremental-tag", "", "Filter by incremental tag (NEW, REMOVED, UNCHANGED)")