rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve probo-agent tray icon and enrollment menu

Browse Source 
Replace the placeholder orange-circle tray icon with the monochrome
Probo logo used in auditor-mode. On macOS, show the icon only (no
menu bar title); keep the title on Windows.

Restructure the context menu: status rows with colored indicators,
an Enroll via… submenu for region selection, and a clearer About
label. Surface enrollment errors in native dialogs instead of stderr.

Fix self-hosted enrollment on macOS by reading the hostname from
osascript's returned value; the default dialog output order broke
URL parsing and silently skipped opening the browser.

Signed-off-by: Ludovic Vielle <ludovic@probo.com>
This commit is contained in:
Ludovic Vielle
2026-07-15 19:10:44 +02:00
parent ae769f52a1
commit 4a56be2e3e
13 changed files with 108 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
pkg/deviceagent/tray/tray_supported.go
View File

@@ -3,7 +3,7 @@
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// to use, copy, modify, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
@@ -23,7 +23,6 @@
package tray
import (
"fmt"
"os"
"os/signal"
"sync"
@@ -87,25 +86,35 @@ func (m enrollmentMenu) hide() {
func onReady(opts Options, done <-chan struct{}) {
setTrayIcons()
systray.SetTitle("Probo")
enrollMenu := setupEnrollmentMenu(opts, done)
setTrayTitle()
connectedItem := systray.AddMenuItem("Connected", "Device is enrolled and reporting")
connectedItem.SetIcon(statusConnectedIconData)
connectedItem.Disable()
connectedItem.Hide()
enrollmentRequiredItem := systray.AddMenuItem(
"Enrollment required",
"Device is not enrolled yet",
)
enrollmentRequiredItem.SetIcon(statusEnrollmentIconData)
enrollmentRequiredItem.Disable()
enrollmentRequiredItem.Hide()
statusUnavailableItem := systray.AddMenuItem(
"Status unavailable",
"Cannot read enrollment status",
)
statusUnavailableItem.SetIcon(statusUnavailableIconData)
statusUnavailableItem.Disable()
statusUnavailableItem.Hide()
systray.AddSeparator()
enrollMenu := setupEnrollmentMenu(opts, done)
aboutItem := systray.AddMenuItem(
fmt.Sprintf("About probo-agent %s", opts.Version),
"About Probo Device Posture Agent…",
"Probo device posture agent",
)
@@ -114,6 +123,7 @@ func onReady(opts Options, done <-chan struct{}) {
if err != nil {
enrollMenu.hide()
connectedItem.Hide()
enrollmentRequiredItem.Hide()
statusUnavailableItem.Show()
systray.SetTooltip("Probo Device Posture Agent — Status unavailable")
@@ -124,11 +134,13 @@ func onReady(opts Options, done <-chan struct{}) {
if enrolled {
enrollMenu.hide()
enrollmentRequiredItem.Hide()
connectedItem.Show()
systray.SetTooltip("Probo Device Posture Agent — Connected")
} else {
enrollMenu.show()
connectedItem.Hide()
enrollmentRequiredItem.Show()
systray.SetTooltip("Probo Device Posture Agent — Enrollment required")
}
}
@@ -173,7 +185,7 @@ func setupEnrollmentMenu(opts Options, done <-chan struct{}) enrollmentMenu {
return enrollmentMenu{items: []*systray.MenuItem{enrollItem}}
}
enrollRoot := systray.AddMenuItem("Enroll in browser", enrollTooltip)
enrollRoot := systray.AddMenuItem("Enroll via…", enrollTooltip)
usItem := enrollRoot.AddSubMenuItem(
"United States (us.probo.com)",