rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Exclude uncategorised category from consent contract

Browse Source 
The uncategorised category is an admin-side inbox for detected
cookies and should not be part of the visitor-facing consent
contract. Filter it out of snapshots so changes to uncategorised
patterns no longer trigger version bumps.

Signed-off-by: Émile Ré <emile@getprobo.com>
This commit is contained in:
Émile Ré
2026-05-02 18:33:07 +04:00
parent 887453fee2
commit 478ccf6785
4 changed files with 88 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/cookiebanner/service_test.go
View File

@@ -211,13 +211,15 @@ func TestBuildSnapshot_RankInvariant(t *testing.T) {
assert.True(t, snapshotsEqual(a, b))
})
t.Run("Necessary comes first and Uncategorised comes last", func(t *testing.T) {
t.Run("Necessary comes first and uncategorised is excluded", func(t *testing.T) {
t.Parallel()
snap := buildSnapshot(banner, mkCategories(0, 1, 2, 3), nil)
require.Len(t, snap.Categories, 4)
require.Len(t, snap.Categories, 3)
assert.Equal(t, coredata.CookieCategoryKindNecessary, snap.Categories[0].Kind)
assert.Equal(t, coredata.CookieCategoryKindUncategorised, snap.Categories[3].Kind)
for _, c := range snap.Categories {
assert.NotEqual(t, coredata.CookieCategoryKindUncategorised, c.Kind)
}
})
}