Fix increment tab counters when linking nodes

Fix #171

Signed-off-by: Sacha Al Himdani <sacha@getprobo.com>
This commit is contained in:
Jonathan
2025-07-20 13:35:54 +02:00
committed by Sacha Al Himdani
parent a673135c3f
commit 4739c0533c
10 changed files with 224 additions and 38 deletions

View File

@@ -1,8 +1,9 @@
import { LinkedControlsCard } from "/components/controls/LinkedControlsCard";
import { useOutletContext } from "react-router";
import { graphql } from "relay-runtime";
import { useMutation, useRefetchableFragment } from "react-relay";
import { useRefetchableFragment } from "react-relay";
import type { DocumentControlsTabFragment$key } from "./__generated__/DocumentControlsTabFragment.graphql";
import { useMutationWithIncrement } from "/hooks/useMutationWithIncrement.ts";
export const controlsFragment = graphql`
fragment DocumentControlsTabFragment on Document
@@ -68,8 +69,24 @@ export default function DocumentControlsTab() {
}>();
const [data, refetch] = useRefetchableFragment(controlsFragment, document);
const controls = data.controls.edges.map((edge) => edge.node);
const [detachControl, isDetaching] = useMutation(detachControlMutation);
const [attachControl, isAttaching] = useMutation(attachControlMutation);
const incrementOptions = {
id: data.id,
node: "controls(first:0)",
};
const [detachControl, isDetaching] = useMutationWithIncrement(
detachControlMutation,
{
...incrementOptions,
value: -1,
},
);
const [attachControl, isAttaching] = useMutationWithIncrement(
attachControlMutation,
{
...incrementOptions,
value: 1,
},
);
const isLoading = isDetaching || isAttaching;
return (
<LinkedControlsCard

View File

@@ -12,11 +12,12 @@ import {
type DialogRef,
} from "@probo/ui";
import { useTranslate } from "@probo/i18n";
import { graphql } from "react-relay";
import { graphql, useRelayEnvironment } from "react-relay";
import { useState } from "react";
import { z } from "zod";
import { useFormWithSchema } from "/hooks/useFormWithSchema";
import { useMutationWithToasts } from "/hooks/useMutationWithToasts";
import { updateStoreCounter } from "/hooks/useMutationWithIncrement";
const uploadEvidenceMutation = graphql`
mutation CreateEvidenceDialogUploadMutation(
@@ -73,6 +74,7 @@ export function CreateEvidenceDialog(props: Props) {
function EvidenceUpload({ measureId, connectionId }: Omit<Props, "ref">) {
const { __ } = useTranslate();
const relayEnv = useRelayEnvironment();
const [mutate, isUpdating] = useMutationWithToasts(uploadEvidenceMutation, {
successMessage: __("Evidence uploaded successfully"),
errorMessage: __("Failed to create evidence"),
@@ -90,6 +92,9 @@ function EvidenceUpload({ measureId, connectionId }: Omit<Props, "ref">) {
uploadables: {
"input.file": file,
},
onSuccess: () => {
updateStoreCounter(relayEnv, measureId, "evidences(first:0)", 1);
},
});
}
};

View File

@@ -1,11 +1,8 @@
import {
graphql,
useMutation,
useRefetchableFragment,
} from "react-relay";
import { graphql, useRefetchableFragment } from "react-relay";
import { useOutletContext } from "react-router";
import { LinkedControlsCard } from "/components/controls/LinkedControlsCard";
import type { MeasureControlsTabFragment$key } from "./__generated__/MeasureControlsTabFragment.graphql";
import { useMutationWithIncrement } from "/hooks/useMutationWithIncrement.ts";
export const controlsFragment = graphql`
fragment MeasureControlsTabFragment on Measure
@@ -73,8 +70,24 @@ export default function MeasureControlsTab() {
const connectionId = data.controls.__id;
const controls = data.controls?.edges?.map((edge) => edge.node) ?? [];
const [detachControl, isDetaching] = useMutation(detachControlMutation);
const [attachControl, isAttaching] = useMutation(attachControlMutation);
const incrementOptions = {
id: data.id,
node: "controls(first:0)",
};
const [detachControl, isDetaching] = useMutationWithIncrement(
detachControlMutation,
{
...incrementOptions,
value: -1,
},
);
const [attachControl, isAttaching] = useMutationWithIncrement(
attachControlMutation,
{
...incrementOptions,
value: 1,
},
);
const isLoading = isDetaching || isAttaching;
return (

View File

@@ -18,7 +18,12 @@ import {
useDialogRef,
} from "@probo/ui";
import { graphql } from "relay-runtime";
import { useFragment, useMutation, usePaginationFragment } from "react-relay";
import {
useFragment,
useMutation,
usePaginationFragment,
useRelayEnvironment,
} from "react-relay";
import { SortableTable } from "/components/SortableTable";
import type { MeasureEvidencesTabFragment_evidence$key } from "./__generated__/MeasureEvidencesTabFragment_evidence.graphql";
import { fileSize, fileType, promisifyMutation, sprintf } from "@probo/helpers";
@@ -27,6 +32,7 @@ import { useOrganizationId } from "/hooks/useOrganizationId";
import { CreateEvidenceDialog } from "../dialog/CreateEvidenceDialog";
import { useState } from "react";
import { EvidenceDownloadDialog } from "../dialog/EvidenceDownloadDialog";
import { updateStoreCounter } from "/hooks/useMutationWithIncrement";
export const evidencesFragment = graphql`
fragment MeasureEvidencesTabFragment on Measure
@@ -134,7 +140,7 @@ export default function MeasureEvidencesTab() {
key={evidence?.id}
onClose={() =>
navigate(
`/organizations/${organizationId}/measures/${measure.id}/evidences`,
`/organizations/${organizationId}/measures/${measure.id}/evidences`
)
}
evidenceId={evidence.id}
@@ -162,6 +168,7 @@ function EvidenceRow(props: {
const [mutate, isDeleting] = useMutation(deleteEvidenceMutation);
const confirm = useConfirm();
const [isDownloading, setIsDownloading] = useState(false);
const relayEnv = useRelayEnvironment();
const handleDelete = () => {
confirm(
@@ -173,16 +180,24 @@ function EvidenceRow(props: {
evidenceId: evidence.id,
},
},
onCompleted: () => {
updateStoreCounter(
relayEnv,
props.measureId,
"evidences(first:0)",
-1
);
},
});
},
{
message: sprintf(
__(
'This will permanently delete the evidence "%s". This action cannot be undone.',
'This will permanently delete the evidence "%s". This action cannot be undone.'
),
evidence.filename,
evidence.filename
),
},
}
);
};

View File

@@ -1,7 +1,8 @@
import { graphql, useFragment, useMutation } from "react-relay";
import { graphql, useFragment } from "react-relay";
import type { MeasureRisksTabFragment$key } from "./__generated__/MeasureRisksTabFragment.graphql";
import { useOutletContext } from "react-router";
import { LinkedRisksCard } from "/components/risks/LinkedRisksCard";
import { useMutationWithIncrement } from "/hooks/useMutationWithIncrement";
export const risksFragment = graphql`
fragment MeasureRisksTabFragment on Measure {
@@ -53,8 +54,24 @@ export default function MeasureRisksTab() {
const connectionId = data.risks.__id;
const risks = data.risks?.edges?.map((edge) => edge.node) ?? [];
const [detachRisk, isDetaching] = useMutation(detachRiskMutation);
const [attachRisk, isAttaching] = useMutation(attachRiskMutation);
const incrementOptions = {
id: data.id,
node: "risks(first:0)",
};
const [detachRisk, isDetaching] = useMutationWithIncrement(
detachRiskMutation,
{
...incrementOptions,
value: -1,
},
);
const [attachRisk, isAttaching] = useMutationWithIncrement(
attachRiskMutation,
{
...incrementOptions,
value: 1,
},
);
const isLoading = isDetaching || isAttaching;
return (

View File

@@ -1,7 +1,8 @@
import { graphql, useFragment, useMutation } from "react-relay";
import { graphql, useFragment } from "react-relay";
import { useOutletContext } from "react-router";
import { LinkedDocumentsCard } from "/components/documents/LinkedDocumentsCard";
import type { RiskDocumentsTabFragment$key } from "./__generated__/RiskDocumentsTabFragment.graphql";
import { useMutationWithIncrement } from "/hooks/useMutationWithIncrement.ts";
export const documentsFragment = graphql`
fragment RiskDocumentsTabFragment on Risk {
@@ -53,8 +54,24 @@ export default function RiskDocumentsTab() {
const connectionId = data.documents.__id;
const documents = data.documents?.edges?.map((edge) => edge.node) ?? [];
const [detachDocument, isDetaching] = useMutation(detachDocumentMutation);
const [attachDocument, isAttaching] = useMutation(attachDocumentMutation);
const incrementOptions = {
id: data.id,
node: "documents(first:0)",
};
const [detachDocument, isDetaching] = useMutationWithIncrement(
detachDocumentMutation,
{
...incrementOptions,
value: -1,
},
);
const [attachDocument, isAttaching] = useMutationWithIncrement(
attachDocumentMutation,
{
...incrementOptions,
value: 1,
},
);
const isLoading = isDetaching || isAttaching;
return (

View File

@@ -1,7 +1,8 @@
import { graphql, useFragment, useMutation } from "react-relay";
import { graphql, useFragment } from "react-relay";
import type { RiskMeasuresTabFragment$key } from "./__generated__/RiskMeasuresTabFragment.graphql";
import { useOutletContext } from "react-router";
import { LinkedMeasuresCard } from "/components/measures/LinkedMeasuresCard";
import { useMutationWithIncrement } from "/hooks/useMutationWithIncrement.ts";
export const measuresFragment = graphql`
fragment RiskMeasuresTabFragment on Risk {
@@ -52,9 +53,24 @@ export default function RiskMeasuresTab() {
const data = useFragment(measuresFragment, risk);
const connectionId = data.measures.__id;
const measures = data.measures?.edges?.map((edge) => edge.node) ?? [];
const [detachMeasure, isDetaching] = useMutation(detachMeasureMutation);
const [attachMeasure, isAttaching] = useMutation(attachMeasureMutation);
const incrementOptions = {
id: data.id,
node: "measures(first:0)",
};
const [detachMeasure, isDetaching] = useMutationWithIncrement(
detachMeasureMutation,
{
...incrementOptions,
value: -1,
},
);
const [attachMeasure, isAttaching] = useMutationWithIncrement(
attachMeasureMutation,
{
...incrementOptions,
value: 1,
},
);
const isLoading = isDetaching || isAttaching;
return (