From 43d6ab38fbf4afd77d8dfef909304f6185765120 Mon Sep 17 00:00:00 2001 From: Bryan Frimin Date: Sun, 15 Mar 2026 13:32:54 +0100 Subject: [PATCH] Fix formatting and React hook dependency lint errors Fix max-len violations by breaking long lines across multiple lines. Fix react-hooks/exhaustive-deps by adding missing deps and removing unnecessary ones. Remove stale eslint-disable comments in DataTable stories. Signed-off-by: Bryan Frimin --- .../src/pages/iam/auth/ActivateAccountPage.tsx | 2 +- .../CompliancePageMailingListPage.tsx | 15 ++++++++------- .../CompliancePageExternalUrlsSection.tsx | 14 ++++++++++++-- .../organizations/documents/DocumentLayout.tsx | 6 +++++- .../settings/WebhooksSettingsPage.tsx | 2 +- .../dialogs/AddApplicabilityStatementDialog.tsx | 5 ++++- .../ui/src/Molecules/Table/DataTable.stories.tsx | 3 +-- 7 files changed, 32 insertions(+), 15 deletions(-) diff --git a/apps/console/src/pages/iam/auth/ActivateAccountPage.tsx b/apps/console/src/pages/iam/auth/ActivateAccountPage.tsx index c91d90162..5dac6bb47 100644 --- a/apps/console/src/pages/iam/auth/ActivateAccountPage.tsx +++ b/apps/console/src/pages/iam/auth/ActivateAccountPage.tsx @@ -111,7 +111,7 @@ export default function ActivateAccountPage() { }); }, }); - }, [__, toast, activateAccount, navigate, safeContinueUrl, searchParams]); + }, [__, toast, activateAccount, navigate, safeContinueUrl]); useEffect(() => { const token = searchParams.get("token"); diff --git a/apps/console/src/pages/organizations/compliance-page/mailing-list/CompliancePageMailingListPage.tsx b/apps/console/src/pages/organizations/compliance-page/mailing-list/CompliancePageMailingListPage.tsx index 82a828350..9d7f5b5fd 100644 --- a/apps/console/src/pages/organizations/compliance-page/mailing-list/CompliancePageMailingListPage.tsx +++ b/apps/console/src/pages/organizations/compliance-page/mailing-list/CompliancePageMailingListPage.tsx @@ -80,13 +80,14 @@ export function CompliancePageMailingListPage(props: { const [replyTo, setReplyTo] = useState(mailingList?.replyTo ?? ""); - const [updateMailingList, isUpdating] = useMutationWithToasts( - updateMailingListMutation, - { - successMessage: __("Mailing list updated successfully"), - errorMessage: __("Failed to update mailing list"), - }, - ); + const [updateMailingList, isUpdating] + = useMutationWithToasts( + updateMailingListMutation, + { + successMessage: __("Mailing list updated successfully"), + errorMessage: __("Failed to update mailing list"), + }, + ); const handleSaveReplyTo = () => { if (!mailingListId) return; diff --git a/apps/console/src/pages/organizations/compliance-page/overview/_components/CompliancePageExternalUrlsSection.tsx b/apps/console/src/pages/organizations/compliance-page/overview/_components/CompliancePageExternalUrlsSection.tsx index 865a85309..5376a41aa 100644 --- a/apps/console/src/pages/organizations/compliance-page/overview/_components/CompliancePageExternalUrlsSection.tsx +++ b/apps/console/src/pages/organizations/compliance-page/overview/_components/CompliancePageExternalUrlsSection.tsx @@ -245,7 +245,10 @@ function ExternalUrlRow(props: { onDragEnd: () => void; onEdit: (node: UrlNode) => void; }) { - const { node, canEdit, connectionId, isDragging, isDropTarget, onDragStart, onDragOver, onDrop, onDragEnd, onEdit } = props; + const { + node, canEdit, connectionId, isDragging, isDropTarget, + onDragStart, onDragOver, onDrop, onDragEnd, onEdit, + } = props; const { __ } = useTranslate(); const [isMouseDown, setIsMouseDown] = useState(false); @@ -361,7 +364,14 @@ export function CompliancePageExternalUrlsSection(props: { const draggedId = draggedEdge.node.id; await updateRank({ - variables: { input: { id: draggedId, name: draggedEdge.node.name, url: draggedEdge.node.url, rank: targetRank } }, + variables: { + input: { + id: draggedId, + name: draggedEdge.node.name, + url: draggedEdge.node.url, + rank: targetRank, + }, + }, updater: (store) => { const connection = store.get(connectionId); if (!connection) return; diff --git a/apps/console/src/pages/organizations/documents/DocumentLayout.tsx b/apps/console/src/pages/organizations/documents/DocumentLayout.tsx index 60a85534b..3759c6f7e 100644 --- a/apps/console/src/pages/organizations/documents/DocumentLayout.tsx +++ b/apps/console/src/pages/organizations/documents/DocumentLayout.tsx @@ -147,7 +147,11 @@ export function DocumentLayout(props: { queryRef: PreloadedQuery )} - + diff --git a/apps/console/src/pages/organizations/settings/WebhooksSettingsPage.tsx b/apps/console/src/pages/organizations/settings/WebhooksSettingsPage.tsx index 0d0ecbbf8..93966522e 100644 --- a/apps/console/src/pages/organizations/settings/WebhooksSettingsPage.tsx +++ b/apps/console/src/pages/organizations/settings/WebhooksSettingsPage.tsx @@ -368,7 +368,7 @@ function WebhookEventsDialog({ useEffect(() => { void loadEvents(); dialogRef.current?.open(); - }, [loadEvents]); + }, [loadEvents, dialogRef]); return ( void; }; -export const AddApplicabilityStatementDialog = forwardRef( +export const AddApplicabilityStatementDialog = forwardRef< + AddApplicabilityStatementDialogRef, + AddApplicabilityStatementDialogProps +>( ({ onClose }, ref) => { const { __ } = useTranslate(); const dialogRef = useDialogRef(); diff --git a/packages/ui/src/Molecules/Table/DataTable.stories.tsx b/packages/ui/src/Molecules/Table/DataTable.stories.tsx index a0b9c4708..96b206258 100644 --- a/packages/ui/src/Molecules/Table/DataTable.stories.tsx +++ b/packages/ui/src/Molecules/Table/DataTable.stories.tsx @@ -1,6 +1,5 @@ import type { Meta, StoryObj } from "@storybook/react"; import { type FC, Fragment, useState } from "react"; -// eslint-disable-next-line import-x/no-unresolved -- storybook v10 subpath export import { fn } from "storybook/test"; import { Badge } from "../../Atoms/Badge/Badge"; @@ -16,7 +15,7 @@ export default { title: "Atoms/DataTable/Cells", component: Fragment as Component, argTypes: {}, - // eslint-disable-next-line @typescript-eslint/no-unsafe-call -- fn type unresolvable due to storybook/test subpath + args: { onUpdate: fn() as (key: string, value: unknown) => void }, } satisfies Meta;