From 438ca439de18d58893cf05a5cd2c7fd691623e78 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89mile=20R=C3=A9?= <emile@getprobo.com>
Date: Mon, 11 May 2026 13:07:30 +0400
Subject: [PATCH] cookie-banner: rename ThirdPartyDetector to ResourceDetector
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The detector emits tracker_resource entries (scripts, iframes, images,
beacons, fonts, fetches, media, service workers); the "third-party"
qualifier was misleading because the same code path also fires for
service workers, which are always same-origin per browser security
rules. Rename the class and file to match what they actually produce.

Signed-off-by: Émile Ré <emile@getprobo.com>
---
 packages/cookie-banner/src/client.ts                          | 4 ++--
 packages/cookie-banner/src/detectors/index.ts                 | 2 +-
 .../{third-party-detector.ts => resource-detector.ts}         | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)
 rename packages/cookie-banner/src/detectors/{third-party-detector.ts => resource-detector.ts} (99%)

diff --git a/packages/cookie-banner/src/client.ts b/packages/cookie-banner/src/client.ts
index 9d78fc219..b9754c956 100644
--- a/packages/cookie-banner/src/client.ts
+++ b/packages/cookie-banner/src/client.ts
@@ -18,7 +18,7 @@ import {
 } from "./activation";
 import { COOKIE_NAME, getConsentCookie, setConsentCookie } from "./cookie";
 import type { Detector } from "./detectors";
-import { CookieDetector, ReportQueue, StorageDetector, ThirdPartyDetector } from "./detectors";
+import { CookieDetector, ReportQueue, ResourceDetector, StorageDetector } from "./detectors";
 import { NotFoundError } from "./errors";
 import { fetchJSON } from "./http";
 import { detectLanguage } from "./i18n";
@@ -316,7 +316,7 @@ export class CookieBannerClient {
     this.detectors = [
       new CookieDetector(this.reportQueue, apiOrigin, knownNames),
       new StorageDetector(this.reportQueue, apiOrigin),
-      new ThirdPartyDetector(this.reportQueue, apiOrigin),
+      new ResourceDetector(this.reportQueue, apiOrigin),
     ];
 
     for (const d of this.detectors) {
diff --git a/packages/cookie-banner/src/detectors/index.ts b/packages/cookie-banner/src/detectors/index.ts
index ba26ef92f..3a6845a4c 100644
--- a/packages/cookie-banner/src/detectors/index.ts
+++ b/packages/cookie-banner/src/detectors/index.ts
@@ -15,7 +15,7 @@
 export type { Detector } from "./detector";
 export { CookieDetector } from "./cookie-detector";
 export { StorageDetector } from "./storage-detector";
-export { ThirdPartyDetector } from "./third-party-detector";
+export { ResourceDetector } from "./resource-detector";
 export { ReportQueue } from "./report-queue";
 export type {
   CookieSource,
diff --git a/packages/cookie-banner/src/detectors/third-party-detector.ts b/packages/cookie-banner/src/detectors/resource-detector.ts
similarity index 99%
rename from packages/cookie-banner/src/detectors/third-party-detector.ts
rename to packages/cookie-banner/src/detectors/resource-detector.ts
index 0060a1791..c2af4d79e 100644
--- a/packages/cookie-banner/src/detectors/third-party-detector.ts
+++ b/packages/cookie-banner/src/detectors/resource-detector.ts
@@ -54,7 +54,7 @@ function mapInitiatorType(it: string): ResourceType | null {
   }
 }
 
-export class ThirdPartyDetector implements Detector {
+export class ResourceDetector implements Detector {
   private readonly queue: ReportQueue;
   private readonly pageOrigin: string;
   private readonly apiOrigin: string;