rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix parsing int error

Browse Source 
Signed-off-by: Bryan Frimin <bryan@probo.com>
This commit is contained in:
Bryan Frimin
2026-07-22 13:20:33 +02:00
parent 81b7ee5fad
commit 3f202002d9
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/certmanager/acme_errors.go
View File

@@ -151,12 +151,12 @@ func parseRetryAfter(header http.Header) (time.Duration, bool) {
} }
// The delta-seconds form is an unsigned decimal integer (RFC 9110 §10.2.3). // The delta-seconds form is an unsigned decimal integer (RFC 9110 §10.2.3).
// Parsing it as unsigned rejects negative or otherwise malformed values so // Parse as signed 64-bit to match time.Duration's underlying type and avoid
// they fall back to the caller's default cooldown instead of collapsing to a // unsigned-to-signed narrowing conversions. Negative or malformed values are
// zero/negative duration that would disable the rate-limit cooldown. A value // treated as unparseable so callers can apply their default cooldown. A value
// larger than time.Duration can hold is clamped to the maximum duration. // larger than time.Duration can hold is clamped to the maximum duration.
if seconds, err := strconv.ParseUint(value, 10, 64); err == nil { if seconds, err := strconv.ParseInt(value, 10, 64); err == nil && seconds >= 0 {
maxSeconds := uint64(math.MaxInt64 / int64(time.Second)) maxSeconds := int64(math.MaxInt64 / int64(time.Second))
if seconds > maxSeconds { if seconds > maxSeconds {
return time.Duration(math.MaxInt64), true return time.Duration(math.MaxInt64), true
} }