rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Guard store updater and handle reorder errors

Browse Source 
Check that the move mutation payload contains the pattern
before removing it from the uncategorised connection. Add
onCompleted error handling to reorder mutations so GraphQL
errors are surfaced to the user.

Signed-off-by: Émile Ré <emile@getprobo.com>
This commit is contained in:
Émile Ré
2026-05-05 11:08:55 +04:00
parent 3b4aa7f971
commit 39db90168c
2 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
apps/console/src/pages/organizations/cookie-banners/configuration/detection/_components/DetectionPatternRow.tsx
View File

@@ -195,6 +195,11 @@ export function DetectionPatternRow({ patternKey, connectionId }: DetectionPatte
}, },
}, },
updater(store) { updater(store) {
const payload = store.getRootField("moveCookiePatternToCategory");
if (!payload?.getLinkedRecord("cookiePattern")) {
return;
}
const conn = store.get(connectionId); const conn = store.get(connectionId);
if (conn) { if (conn) {
ConnectionHandler.deleteNode(conn, pattern.id); ConnectionHandler.deleteNode(conn, pattern.id);

10
apps/console/src/pages/organizations/cookie-banners/configuration/display/_components/CategorySection.tsx
View File

@@ -562,6 +562,11 @@ export function CategorySection({ categoryKey, connectionId }: CategorySectionPr
const above = allCategories[selfIndex - 1]; const above = allCategories[selfIndex - 1];
reorderCategory({ reorderCategory({
variables: { input: { cookieCategoryId: category.id, rank: above.rank } }, variables: { input: { cookieCategoryId: category.id, rank: above.rank } },
onCompleted(_, errors) {
if (errors?.length) {
toast({ title: __("Error"), description: errors[0].message, variant: "error" });
}
},
onError(error) { onError(error) {
toast({ title: __("Error"), description: formatError(__("Failed to reorder"), error as GraphQLError), variant: "error" }); toast({ title: __("Error"), description: formatError(__("Failed to reorder"), error as GraphQLError), variant: "error" });
}, },
@@ -573,6 +578,11 @@ export function CategorySection({ categoryKey, connectionId }: CategorySectionPr
const below = allCategories[selfIndex + 1]; const below = allCategories[selfIndex + 1];
reorderCategory({ reorderCategory({
variables: { input: { cookieCategoryId: category.id, rank: below.rank } }, variables: { input: { cookieCategoryId: category.id, rank: below.rank } },
onCompleted(_, errors) {
if (errors?.length) {
toast({ title: __("Error"), description: errors[0].message, variant: "error" });
}
},
onError(error) { onError(error) {
toast({ title: __("Error"), description: formatError(__("Failed to reorder"), error as GraphQLError), variant: "error" }); toast({ title: __("Error"), description: formatError(__("Failed to reorder"), error as GraphQLError), variant: "error" });
}, },