rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix filename content type regression

Browse Source 
Signed-off-by: Bryan Frimin <bryan@getprobo.com>
This commit is contained in:
Bryan Frimin
2025-10-09 17:03:35 +02:00
parent 6b4ab326c4
commit 39383662d7
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/probo/file_service.go
View File

@@ -18,6 +18,7 @@ import (
"context" "context"
"fmt" "fmt"
"io" "io"
"net/url"
"time" "time"
"github.com/aws/aws-sdk-go-v2/aws" "github.com/aws/aws-sdk-go-v2/aws"
@@ -158,12 +159,17 @@ func (s FileService) GenerateFileTempURL(
presignClient := s3.NewPresignClient(s.svc.s3) presignClient := s3.NewPresignClient(s.svc.s3)
// Use RFC 6266/5987 encoding for filename with UTF-8 support
encodedFilename := url.QueryEscape(file.FileName)
contentDisposition := fmt.Sprintf("attachment; filename=\"%s\"; filename*=UTF-8''%s",
encodedFilename, encodedFilename)
presignedReq, err := presignClient.PresignGetObject(ctx, &s3.GetObjectInput{ presignedReq, err := presignClient.PresignGetObject(ctx, &s3.GetObjectInput{
Bucket: aws.String(s.svc.bucket), Bucket: aws.String(s.svc.bucket),
Key: aws.String(file.FileKey), Key: aws.String(file.FileKey),
ResponseCacheControl: aws.String("max-age=3600, public"), ResponseCacheControl: aws.String("max-age=3600, public"),
ResponseContentType: aws.String(file.MimeType), ResponseContentType: aws.String(file.MimeType),
ResponseContentDisposition: aws.String(fmt.Sprintf("attachment; filename=\"%s\"", file.FileName)), ResponseContentDisposition: aws.String(fmt.Sprintf("attachment; filename=\"%s\"", contentDisposition)),
}, func(opts *s3.PresignOptions) { }, func(opts *s3.PresignOptions) {
opts.Expires = expiresIn opts.Expires = expiresIn
}) })