rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix framework export for evidence link

Browse Source 
Signed-off-by: Sacha Al Himdani <sacha@getprobo.com>
This commit is contained in:
Sacha Al Himdani
2025-09-04 17:32:21 +02:00
parent 548c6c3758
commit 393672378a
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/probo/framework_service.go
View File

@@ -194,6 +194,12 @@ func (s FrameworkService) Export(
} }
for _, evidence := range evidences { for _, evidence := range evidences {
if evidence.Type != coredata.EvidenceTypeFile ||
evidence.State != coredata.EvidenceStateFulfilled ||
evidence.ObjectKey == "" {
continue
}
object, err := s.svc.s3.GetObject( object, err := s.svc.s3.GetObject(
ctx, ctx,
&s3.GetObjectInput{ &s3.GetObjectInput{
@@ -206,10 +212,6 @@ func (s FrameworkService) Export(
} }
defer object.Body.Close() defer object.Body.Close()
if err != nil {
return fmt.Errorf("cannot download evidence: %w", err)
}
w, err := archive.Create(fmt.Sprintf("%s/%s/%s/%s", framework.Name, control.SectionTitle, measure.Name, evidence.Filename)) w, err := archive.Create(fmt.Sprintf("%s/%s/%s/%s", framework.Name, control.SectionTitle, measure.Name, evidence.Filename))
if err != nil { if err != nil {
return fmt.Errorf("cannot create evidence in archive: %w", err) return fmt.Errorf("cannot create evidence in archive: %w", err)