rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Verify Crisp website ownership before connecting

Browse Source 
Crisp is a managed (Model B) connector: Probo holds one plugin token
server-side and each connection carries only a Website ID. Nothing
stops one organization from entering another organization's Website
ID, so prove control of the website before creating the connection.

Probo derives a per-(organization, website) verification code as an
HMAC over the token secret and exposes it through a new
crispVerificationCode query. The customer pastes it into the Probo
plugin's per-website settings; at connect time the resolver reads the
setting back through the managed plugin token and requires a
constant-time match before any row is written. The managed key and
plugin ID come from bootstrap, so the connector stays hidden until the
deployment configures them.

The settings fetch is injected so the create-time gate's branch wiring
is unit-tested (mismatch and not-subscribed reject, internal errors
stay generic, a matching code passes), and the managed-versus-client
key resolution is covered too.

Signed-off-by: Aurélien Sibiril <81782+aureliensibiril@users.noreply.github.com>
This commit is contained in:
Aurélien Sibiril
2026-07-11 16:50:32 +02:00
parent 6435a52f47
commit 37121e7bac
24 changed files with 1294 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
pkg/probodconfig/connector_config.go
View File

@@ -30,6 +30,17 @@ type ConnectorConfig struct {
RawConfig any `json:"config,omitempty"`
Settings any `json:"-"`
RawSettings any `json:"settings,omitempty"`
// APIKey holds the Probo-supplied credential for an api_key-protocol
// connector (ManagedAPIKey providers such as Crisp). It is resolved
// from RawConfig by UnmarshalJSON and registered on the provider
// Registry by probod. Empty for OAuth2 connectors.
APIKey string `json:"-"`
// ResourceID holds an optional Probo-supplied resource identifier for an
// api_key-protocol connector, distinct from the credential (e.g. the
// Crisp plugin ID required by the per-website plugin API). Resolved from
// RawConfig by UnmarshalJSON and registered on the provider Registry by
// probod. Empty for connectors that need no such identifier.
ResourceID string `json:"-"`
}
type ConnectorConfigOAuth2 struct {
@@ -42,6 +53,17 @@ type ConnectorConfigOAuth2 struct {
IntegrationSlug string `json:"integration-slug,omitempty"`
}
// ConnectorConfigAPIKey carries the Probo-held API key for a
// ManagedAPIKey connector (e.g. Crisp's marketplace plugin token). The
// operator supplies it via bootstrap env; probod registers it on the
// provider Registry so the create-connector resolver can inject it.
// ResourceID is an optional companion identifier (e.g. the Crisp plugin
// ID) some managed connectors need beyond the credential.
type ConnectorConfigAPIKey struct {
APIKey string `json:"api-key"`
ResourceID string `json:"resource-id,omitempty"`
}
func (c *Config) GetSlackSigningSecret() string {
if c.Notifications.Slack.SigningSecret != "" {
return c.Notifications.Slack.SigningSecret
@@ -99,6 +121,14 @@ func (c *ConnectorConfig) UnmarshalJSON(data []byte) error {
oauth2Connector.IntegrationSlug = config.IntegrationSlug
c.Config = &oauth2Connector
case connector.ProtocolAPIKey:
var config ConnectorConfigAPIKey
if err := json.NewDecoder(bytes.NewReader(tmp.RawConfig)).Decode(&config); err != nil {
return fmt.Errorf("cannot unmarshal api key connector config: %w", err)
}
c.APIKey = config.APIKey
c.ResourceID = config.ResourceID
default:
return fmt.Errorf("unknown connector protocol: %q", c.Protocol)
}