rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Return campaign status sentinels without wrapping

Browse Source 
Drop CampaignStatusError from errors.go and map coredata status to
client errors in the service layer only. Cancel on terminal statuses
uses the same sentinels instead of fmt status strings.

Signed-off-by: Cursor Agent <cursoragent@cursor.com>

Co-authored-by: Bryan FRIMIN <bryan@frimin.fr>
This commit is contained in:
Cursor Agent
2026-07-27 13:06:39 +00:00
parent c187ea7124
commit 352c551e53
3 changed files with 28 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
pkg/accessreview/errors.go
View File

@@ -20,11 +20,7 @@
package accessreview
import (
"errors"
"go.probo.inc/probo/pkg/coredata"
)
import "errors"
var (
ErrCampaignMissingSources = errors.New("cannot start campaign: no scope sources configured")
@@ -33,18 +29,3 @@ var (
ErrCampaignCompleted = errors.New("campaign is completed")
ErrCampaignCancelled = errors.New("campaign is cancelled")
)
func CampaignStatusError(status coredata.AccessReviewCampaignStatus) error {
switch status {
case coredata.AccessReviewCampaignStatusInProgress:
return ErrCampaignInProgress
case coredata.AccessReviewCampaignStatusPendingActions:
return ErrCampaignPendingActions
case coredata.AccessReviewCampaignStatusCompleted:
return ErrCampaignCompleted
case coredata.AccessReviewCampaignStatusCancelled:
return ErrCampaignCancelled
default:
return ErrCampaignInProgress
}
}