rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Do not use avatar for tracker third party

Browse Source 
Signed-off-by: Émile Ré <emile@probo.com>
This commit is contained in:
Émile Ré
2026-05-28 15:07:41 +02:00
parent 4520b10187
commit 33ddba9770
3 changed files with 10 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
apps/console/src/pages/organizations/cookie-banners/configuration/trackers/CookieBannerTrackersPage.tsx
View File

@@ -87,7 +87,6 @@ const trackersFragment = graphql`
... on CommonThirdParty { ... on CommonThirdParty {
id id
name name
logoUrl
} }
} }
trackerPatterns( trackerPatterns(
@@ -218,6 +217,15 @@ export default function CookieBannerTrackersPage({
onBlur={handleQuerySubmit} onBlur={handleQuerySubmit}
className="w-72" className="w-72"
/> />
<Select
value={thirdPartyFilter ?? "ALL"}
onValueChange={handleThirdPartyFilterChange}
>
<Option value="ALL">{__("All third parties")}</Option>
{linkedThirdParties.map(party => (
<Option key={party.id} value={party.id}>{party.name}</Option>
))}
</Select>
<Select <Select
value={trackerTypeFilter ?? "ALL"} value={trackerTypeFilter ?? "ALL"}
onValueChange={handleTrackerTypeFilterChange} onValueChange={handleTrackerTypeFilterChange}
@@ -247,15 +255,6 @@ export default function CookieBannerTrackersPage({
<Option key={category.id} value={category.id}>{category.name}</Option> <Option key={category.id} value={category.id}>{category.name}</Option>
))} ))}
</Select> </Select>
<Select
value={thirdPartyFilter ?? "ALL"}
onValueChange={handleThirdPartyFilterChange}
>
<Option value="ALL">{__("All third parties")}</Option>
{linkedThirdParties.map(party => (
<Option key={party.id} value={party.id}>{party.name}</Option>
))}
</Select>
</div> </div>
<div className={isPending ? "opacity-50 pointer-events-none transition-opacity" : ""}> <div className={isPending ? "opacity-50 pointer-events-none transition-opacity" : ""}>

7
apps/console/src/pages/organizations/cookie-banners/configuration/trackers/_components/TrackerPatternPropertiesSection.tsx
View File

@@ -14,7 +14,7 @@
import { humanizeSeconds } from "@probo/helpers"; import { humanizeSeconds } from "@probo/helpers";
import { useTranslate } from "@probo/i18n"; import { useTranslate } from "@probo/i18n";
import { Avatar, Badge, Card, PropertyRow } from "@probo/ui"; import { Badge, Card, PropertyRow } from "@probo/ui";
import { graphql, useFragment } from "react-relay"; import { graphql, useFragment } from "react-relay";
import type { TrackerPatternPropertiesSection_trackerPattern$key } from "#/__generated__/core/TrackerPatternPropertiesSection_trackerPattern.graphql"; import type { TrackerPatternPropertiesSection_trackerPattern$key } from "#/__generated__/core/TrackerPatternPropertiesSection_trackerPattern.graphql";
@@ -106,17 +106,12 @@ export function TrackerPatternPropertiesSection({
{pattern.thirdParty {pattern.thirdParty
? ( ? (
<div className="flex items-center gap-2"> <div className="flex items-center gap-2">
<Avatar name={pattern.thirdParty.name} />
<span className="text-sm">{pattern.thirdParty.name}</span> <span className="text-sm">{pattern.thirdParty.name}</span>
</div> </div>
) )
: pattern.commonThirdParty : pattern.commonThirdParty
? ( ? (
<div className="flex items-center gap-2"> <div className="flex items-center gap-2">
<Avatar
name={pattern.commonThirdParty.name}
src={pattern.commonThirdParty.logoUrl}
/>
<span className="text-sm">{pattern.commonThirdParty.name}</span> <span className="text-sm">{pattern.commonThirdParty.name}</span>
</div> </div>
) )

7
apps/console/src/pages/organizations/cookie-banners/configuration/trackers/_components/TrackerPatternRow.tsx
View File

@@ -16,7 +16,6 @@ import { EyeIcon, EyeSlashIcon } from "@phosphor-icons/react";
import { formatError, type GraphQLError } from "@probo/helpers"; import { formatError, type GraphQLError } from "@probo/helpers";
import { useTranslate } from "@probo/i18n"; import { useTranslate } from "@probo/i18n";
import { import {
Avatar,
Badge, Badge,
Dropdown, Dropdown,
IconArrowBoxLeft, IconArrowBoxLeft,
@@ -64,7 +63,6 @@ const trackerPatternFragment = graphql`
commonThirdParty { commonThirdParty {
id id
name name
logoUrl
} }
} }
`; `;
@@ -328,17 +326,12 @@ export function TrackerPatternRow({ patternKey, connectionId }: TrackerPatternRo
{pattern.thirdParty {pattern.thirdParty
? ( ? (
<div className="flex items-center gap-2 min-w-0"> <div className="flex items-center gap-2 min-w-0">
<Avatar name={pattern.thirdParty.name} />
<span className="truncate">{pattern.thirdParty.name}</span> <span className="truncate">{pattern.thirdParty.name}</span>
</div> </div>
) )
: pattern.commonThirdParty : pattern.commonThirdParty
? ( ? (
<div className="flex items-center gap-2 min-w-0"> <div className="flex items-center gap-2 min-w-0">
<Avatar
name={pattern.commonThirdParty.name}
src={pattern.commonThirdParty.logoUrl}
/>
<span className="truncate">{pattern.commonThirdParty.name}</span> <span className="truncate">{pattern.commonThirdParty.name}</span>
</div> </div>
) )