rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make tracker pattern displayName read-only

Browse Source 
The displayName field was always predictable from pattern + matchType
and allowing edits added unnecessary complexity. Remove displayName
from UpdateTrackerPatternInput across all surfaces (GraphQL, MCP, CLI,
n8n) and make the frontend show it as non-editable text.

Signed-off-by: Émile Ré <emile@getprobo.com>
This commit is contained in:
Émile Ré
2026-05-06 19:31:23 +04:00
parent c0d0221be1
commit 31bfbefc45
13 changed files with 16 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
e2e/console/tracker_pattern_test.go
View File

@@ -192,7 +192,7 @@ func TestTrackerPattern_Create(t *testing.T) {
func TestTrackerPattern_Update(t *testing.T) {
t.Parallel()
t.Run("update displayName and description", func(t *testing.T) {
t.Run("update description", func(t *testing.T) {
t.Parallel()
owner := testutil.NewClient(t, testutil.RoleOwner)
@@ -234,14 +234,13 @@ func TestTrackerPattern_Update(t *testing.T) {
err := owner.Execute(query, map[string]any{
"input": map[string]any{
"trackerPatternId": patternID,
"displayName": "Updated Name",
"description": "Updated description",
},
}, &result)
require.NoError(t, err)
assert.Equal(t, patternID, result.UpdateTrackerPattern.TrackerPattern.ID)
assert.Equal(t, "Updated Name", result.UpdateTrackerPattern.TrackerPattern.DisplayName)
assert.Equal(t, "Original Name", result.UpdateTrackerPattern.TrackerPattern.DisplayName)
assert.Equal(t, "Updated description", result.UpdateTrackerPattern.TrackerPattern.Description)
assert.Equal(t, bannerID, result.UpdateTrackerPattern.CookieBanner.ID)
})
@@ -655,7 +654,7 @@ func TestTrackerPattern_RBAC(t *testing.T) {
`, map[string]any{
"input": map[string]any{
"trackerPatternId": patternID,
"displayName": "Updated by Viewer",
"description": "Updated by Viewer",
},
})
testutil.RequireForbiddenError(t, err, "viewer should not be able to update tracker pattern")