From 2f8aef99273912353f76c23f787239b705862568 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89mile=20R=C3=A9?= Date: Mon, 15 Dec 2025 17:20:42 +0100 Subject: [PATCH] Fix missing return statements MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Émile Ré --- apps/trust/src/components/RequestAccessDialog.tsx | 1 + pkg/server/api/trust/v1/v1_resolver.go | 2 +- pkg/validator/validator_string.go | 4 ++-- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/apps/trust/src/components/RequestAccessDialog.tsx b/apps/trust/src/components/RequestAccessDialog.tsx index 52a357898..6597c9cad 100644 --- a/apps/trust/src/components/RequestAccessDialog.tsx +++ b/apps/trust/src/components/RequestAccessDialog.tsx @@ -67,6 +67,7 @@ export function RequestAccessDialog({ if (error.field === "email") { setError(error.field, {message: error.message}) } + return; } toast({ title: __("Error"), diff --git a/pkg/server/api/trust/v1/v1_resolver.go b/pkg/server/api/trust/v1/v1_resolver.go index 7f9a2a9cf..70a84de8e 100644 --- a/pkg/server/api/trust/v1/v1_resolver.go +++ b/pkg/server/api/trust/v1/v1_resolver.go @@ -361,7 +361,7 @@ func (r *mutationResolver) RequestDocumentAccess(ctx context.Context, input type email := input.Email tokenData := TokenAccessFromContext(ctx) if tokenData != nil { - *email = tokenData.Email + email = &tokenData.Email } if email == nil { return nil, fmt.Errorf("email is required for unauthenticated users") diff --git a/pkg/validator/validator_string.go b/pkg/validator/validator_string.go index 30e152f7f..6fcd21904 100644 --- a/pkg/validator/validator_string.go +++ b/pkg/validator/validator_string.go @@ -258,7 +258,7 @@ func NotOneOfSlice[T any](disallowed []T) ValidatorFunc { // First try exact match with DeepEqual for _, disallowedVal := range disallowed { if reflect.DeepEqual(actualValue, disallowedVal) { - newValidationError( + return newValidationError( ErrorCodeInvalidEnum, fmt.Sprintf("must not be one of: %s", strings.Join(disallowedStrings, ", ")), ) @@ -268,7 +268,7 @@ func NotOneOfSlice[T any](disallowed []T) ValidatorFunc { // Then try string comparison (for custom string types) valueStr := fmt.Sprint(actualValue) if disallowedMap[valueStr] { - newValidationError( + return newValidationError( ErrorCodeInvalidEnum, fmt.Sprintf("must not be one of: %s", strings.Join(disallowedStrings, ", ")), )