Fix access review e2e tests after API refactor

The campaign source node test queried entries before starting the
campaign, and the lifecycle test used the old accessEntry field name
instead of accessReviewEntry.

Signed-off-by: Bryan Frimin <bryan@probo.com>
This commit is contained in:
Bryan Frimin
2026-06-15 15:53:49 +02:00
parent 67a68da371
commit 2dc34df4e1

View File

@@ -867,6 +867,24 @@ func TestAccessReviewCampaignSource_Node(t *testing.T) {
campaignSourceID := campaignResult.Node.Sources[0].ID campaignSourceID := campaignResult.Node.Sources[0].ID
const startQuery = `
mutation($input: StartAccessReviewCampaignInput!) {
startAccessReviewCampaign(input: $input) {
accessReviewCampaign {
id
status
}
}
}
`
err = owner.Execute(startQuery, map[string]any{
"input": map[string]any{
"accessReviewCampaignId": campaignID,
},
}, nil)
require.NoError(t, err)
const nodeQuery = ` const nodeQuery = `
query($id: ID!) { query($id: ID!) {
node(id: $id) { node(id: $id) {
@@ -899,8 +917,15 @@ func TestAccessReviewCampaignSource_Node(t *testing.T) {
} `json:"node"` } `json:"node"`
} }
err = owner.Execute(nodeQuery, map[string]any{"id": campaignSourceID}, &nodeResult) require.Eventually(t, func() bool {
require.NoError(t, err) err := owner.Execute(nodeQuery, map[string]any{"id": campaignSourceID}, &nodeResult)
if err != nil {
return false
}
return nodeResult.Node.Entries.TotalCount > 0
}, 60*time.Second, 1*time.Second, "campaign source should have entries after start")
assert.Equal(t, "AccessReviewCampaignSource", nodeResult.Node.Typename) assert.Equal(t, "AccessReviewCampaignSource", nodeResult.Node.Typename)
assert.Equal(t, campaignSourceID, nodeResult.Node.ID) assert.Equal(t, campaignSourceID, nodeResult.Node.ID)
assert.Equal(t, campaignID, nodeResult.Node.Campaign.ID) assert.Equal(t, campaignID, nodeResult.Node.Campaign.ID)
@@ -1333,7 +1358,7 @@ func TestAccessReviewCampaign_FullLifecycle(t *testing.T) {
const recordDecisionQuery = ` const recordDecisionQuery = `
mutation($input: RecordAccessReviewEntryDecisionInput!) { mutation($input: RecordAccessReviewEntryDecisionInput!) {
recordAccessReviewEntryDecision(input: $input) { recordAccessReviewEntryDecision(input: $input) {
accessEntry { accessReviewEntry {
id id
decision decision
decidedAt decidedAt
@@ -1358,7 +1383,7 @@ func TestAccessReviewCampaign_FullLifecycle(t *testing.T) {
ID string `json:"id"` ID string `json:"id"`
Decision string `json:"decision"` Decision string `json:"decision"`
} `json:"decisionHistory"` } `json:"decisionHistory"`
} `json:"accessEntry"` } `json:"accessReviewEntry"`
} `json:"recordAccessReviewEntryDecision"` } `json:"recordAccessReviewEntryDecision"`
} }