Drop progress reporting from banner tracker reset
The ResetProgressFunc callback streamed per-phase messages from inside the reset transaction, so a rollback could leave already-printed progress describing work that never committed. Remove the callback entirely; the final result summary printed by proboctl still conveys the outcome without the misleading intermediate output. Signed-off-by: Émile Ré <emile@probo.com>
This commit is contained in:
@@ -89,11 +89,7 @@ func newCmdResetTrackers(f *cmdutil.Factory) *cobra.Command {
|
||||
|
||||
_, _ = fmt.Fprintf(out, "Running %s on banner %s.\n", mode, bannerID.String())
|
||||
|
||||
progress := func(message string) {
|
||||
_, _ = fmt.Fprintf(out, " %s\n", message)
|
||||
}
|
||||
|
||||
result, err := cookiebanner.ResetBannerTrackers(ctx, pgClient, scope, bannerID, flagMappingOnly, keyword, progress)
|
||||
result, err := cookiebanner.ResetBannerTrackers(ctx, pgClient, scope, bannerID, flagMappingOnly, keyword)
|
||||
if err != nil {
|
||||
return fmt.Errorf("cannot reset banner %s: %w", bannerID, err)
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user