Address PR review feedback for OIDC login

- Remove sensitive nonce values from error messages to prevent logging leaks
- Guard ticker intervals against non-positive durations in SAML domain
  verifier and garbage collector to prevent panics
- Require both client ID and client secret for Google/Microsoft OIDC
  providers to be marked as enabled
- Replace http.DefaultClient with kit/httpclient for JWKS fetching to
  ensure proper timeouts
- Fix eslint indentation in SignInPage OIDC button click handler

Signed-off-by: Bryan Frimin <bryan@getprobo.com>
This commit is contained in:
Bryan Frimin
2026-03-21 19:43:14 +01:00
parent 3066e7d14c
commit 29b41208f3
5 changed files with 31 additions and 20 deletions

View File

@@ -69,6 +69,10 @@ func (v *SAMLDomainVerifier) Run(ctx context.Context) error {
v.runOnce(ctx)
if v.interval <= 0 {
return fmt.Errorf("cannot run SAML domain verifier: interval must be greater than zero")
}
ticker := time.NewTicker(v.interval)
defer ticker.Stop()