Remove third-party disambiguation agent and matching
The tracker-mapping worker no longer auto-creates or auto-links org third parties, so the heuristic ranker, the disambiguation agent, and the catalog-to-org seeding helpers are dead code. Delete pkg/thirdparty/match.go (RankCandidates, ScoredCandidate, LinkToCommon, CreateFromCommon, suffix stripping, score thresholds) and disambiguation_agent.go, along with their tests. Drop the ThirdPartyDisambiguation agent slot and the worker's DisambiguationAgentTimeout from probodconfig, the builder env wiring, and the builder tests. Remove the matching helm surface too: the thirdPartyDisambiguation agent values, the disambiguationAgentTimeout worker tuning, and the AGENT_THIRD_PARTY_DISAMBIGUATION_* / TRACKER_MAPPING_DISAMBIGUATION_AGENT _TIMEOUT environment mappings, with a chart changelog note. The probod config is built from env lookups with defaults, so a lingering value in an older deployment is simply ignored. Signed-off-by: Émile Ré <emile@probo.com>
This commit is contained in:
@@ -4,6 +4,10 @@ All notable changes to the Probo Helm chart will be documented in this file.
|
||||
|
||||
## Unreleased
|
||||
|
||||
### Removed
|
||||
|
||||
- `thirdPartyDisambiguation` agent config slot and `trackerMappingWorker.disambiguationAgentTimeout`; the tracker-mapping worker no longer runs a third-party disambiguation agent
|
||||
|
||||
## [0.5.0] - 2026-06-09
|
||||
|
||||
### Added
|
||||
|
||||
@@ -281,23 +281,6 @@ spec:
|
||||
- name: THIRD_PARTY_VETTING_STALE_AFTER
|
||||
value: {{ .Values.probo.thirdPartyVettingWorker.staleAfter | quote }}
|
||||
{{- end }}
|
||||
# Third-party Disambiguation Agent
|
||||
{{- if .Values.probo.thirdPartyDisambiguation.provider }}
|
||||
- name: AGENT_THIRD_PARTY_DISAMBIGUATION_PROVIDER
|
||||
value: {{ .Values.probo.thirdPartyDisambiguation.provider | quote }}
|
||||
{{- end }}
|
||||
{{- if .Values.probo.thirdPartyDisambiguation.modelName }}
|
||||
- name: AGENT_THIRD_PARTY_DISAMBIGUATION_MODEL_NAME
|
||||
value: {{ .Values.probo.thirdPartyDisambiguation.modelName | quote }}
|
||||
{{- end }}
|
||||
{{- if .Values.probo.thirdPartyDisambiguation.temperature }}
|
||||
- name: AGENT_THIRD_PARTY_DISAMBIGUATION_TEMPERATURE
|
||||
value: {{ .Values.probo.thirdPartyDisambiguation.temperature | quote }}
|
||||
{{- end }}
|
||||
{{- if .Values.probo.thirdPartyDisambiguation.maxTokens }}
|
||||
- name: AGENT_THIRD_PARTY_DISAMBIGUATION_MAX_TOKENS
|
||||
value: {{ .Values.probo.thirdPartyDisambiguation.maxTokens | quote }}
|
||||
{{- end }}
|
||||
# Tracker Mapping Agent
|
||||
{{- if .Values.probo.trackerMapping.provider }}
|
||||
- name: AGENT_TRACKER_MAPPING_PROVIDER
|
||||
@@ -353,10 +336,6 @@ spec:
|
||||
- name: TRACKER_MAPPING_AGENT_MAX_TURNS
|
||||
value: {{ .Values.probo.trackerMappingWorker.agentMaxTurns | quote }}
|
||||
{{- end }}
|
||||
{{- if .Values.probo.trackerMappingWorker.disambiguationAgentTimeout }}
|
||||
- name: TRACKER_MAPPING_DISAMBIGUATION_AGENT_TIMEOUT
|
||||
value: {{ .Values.probo.trackerMappingWorker.disambiguationAgentTimeout | quote }}
|
||||
{{- end }}
|
||||
# Common Pattern Enrichment Worker
|
||||
{{- if .Values.probo.commonPatternEnrichmentWorker.interval }}
|
||||
- name: COMMON_PATTERN_ENRICHMENT_INTERVAL
|
||||
|
||||
@@ -185,15 +185,6 @@ probo:
|
||||
# maxConcurrency: 1
|
||||
# staleAfter: 1500
|
||||
|
||||
# Third-party disambiguation agent (optional; runs inside the tracker
|
||||
# mapping worker to pick the best matching org third party). Falls back
|
||||
# to trackerMapping when its provider is unset.
|
||||
# thirdPartyDisambiguation:
|
||||
# provider: "openai"
|
||||
# modelName: "gpt-4o"
|
||||
# temperature: "0.4"
|
||||
# maxTokens: "4096"
|
||||
|
||||
# Tracker mapping agent (optional, auto-links tracker patterns to vendors)
|
||||
# trackerMapping:
|
||||
# provider: "openai"
|
||||
@@ -210,7 +201,7 @@ probo:
|
||||
# maxTokens: "4096"
|
||||
|
||||
# Tracker mapping worker tuning (optional; seconds for
|
||||
# interval/staleAfter/agentTimeout/disambiguationAgentTimeout).
|
||||
# interval/staleAfter/agentTimeout).
|
||||
# Keep concurrency modest to stay under OpenAI/Firecrawl limits and the DB pool.
|
||||
# trackerMappingWorker:
|
||||
# interval: 10
|
||||
@@ -218,7 +209,6 @@ probo:
|
||||
# staleAfter: 600
|
||||
# agentTimeout: 45
|
||||
# agentMaxTurns: 10
|
||||
# disambiguationAgentTimeout: 45
|
||||
|
||||
# Common-pattern enrichment worker tuning (optional; seconds for
|
||||
# interval/staleAfter/agentTimeout).
|
||||
|
||||
@@ -286,15 +286,6 @@ probo:
|
||||
maxConcurrency: 1
|
||||
staleAfter: 1500
|
||||
|
||||
# Third-party disambiguation agent (optional; runs inside the tracker
|
||||
# mapping worker to pick the best matching org third party). Falls back
|
||||
# to trackerMapping when its provider is unset.
|
||||
thirdPartyDisambiguation:
|
||||
provider: ""
|
||||
modelName: ""
|
||||
temperature: ""
|
||||
maxTokens: ""
|
||||
|
||||
# Tracker mapping agent (optional, requires openai.apiKey or anthropic key)
|
||||
trackerMapping:
|
||||
provider: ""
|
||||
@@ -311,16 +302,15 @@ probo:
|
||||
maxTokens: ""
|
||||
|
||||
# Tracker mapping background worker tuning (optional). interval,
|
||||
# staleAfter, agentTimeout, and disambiguationAgentTimeout are in
|
||||
# seconds. Keep concurrency modest to stay under OpenAI/Firecrawl rate
|
||||
# limits and the database connection pool.
|
||||
# staleAfter, and agentTimeout are in seconds. Keep concurrency modest
|
||||
# to stay under OpenAI/Firecrawl rate limits and the database
|
||||
# connection pool.
|
||||
trackerMappingWorker:
|
||||
interval: 10
|
||||
maxConcurrency: 3
|
||||
staleAfter: 600
|
||||
agentTimeout: 45
|
||||
agentMaxTurns: 10
|
||||
disambiguationAgentTimeout: 45
|
||||
|
||||
# Common-pattern enrichment background worker tuning (optional).
|
||||
# interval, staleAfter, and agentTimeout are in seconds.
|
||||
|
||||
Reference in New Issue
Block a user